{{ role }}_classes interfaces no longer work.

[Juan Antonio Osorio Robles]

Found by Rhys Oxenham:

The *_classes interface that's documented here: https://docs.openstack.org/tripleo-docs/latest/install/advanced_deployment/node_config.html no longer works.

this is because https://github.com/openstack/tripleo-heat-templates/blob/master/puppet/config.role.j2.yaml which includes the relevant puppet file ( https://github.com/openstack/tripleo-heat-templates/blob/master/puppet/manifests/overcloud_role.pp ) is no longer being included anywhere.

[Steven Hardy (shardy)]

Confirmed by inspection, I think this got broken in the refactor to use ansible to drive the deploy steps, looking into a fix, but containers make this harder as we now have two places where step_config is defined, one that's consolidated into /var/lib/tripleo-config/puppet_step_config.pp (we can add the missing puppet code here easily I think), and then in the per-service docker/services/file for docker_config.

The second case I'm less clear on, we can't really apply a per-role parameter to all docker_config's, as we have no way to know which puppet apply should have the arbitrary additional hiera include?

[Rhys Oxenham (rdoxenham)]

To clarify, I was trying to use the following environment file:

(undercloud) [stack@undercloud ~]$ cat disable_v2.yml
parameter_defaults:
  ControllerExtraConfig:
    controller_classes:
    - keystone::disable_v2_api

That Puppet class was something I copied into the guest manually, and when executed locally it functions as expected. I ran into this bug when I couldn't figure out why it wasn't being called by TripleO. Thanks for your help.

[Rhys Oxenham (rdoxenham)]

For reference, this is the class I was attempting to execute - https://review.openstack.org/532801

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/532811

[Steven Hardy (shardy)]

Ok further information, this is a regression since https://review.openstack.org/#/c/462211/

The patch posted above is WIP but aims to solve the baremetal part of this, e.g to return us to the old behavior, however we need further discussion to figure out if this can be supported for the containerized case - currently I'm not sure that it can.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/532811
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=bb9fd2c61a9ab41c57f427e13cd6a8bae391049e
Submitter: Zuul
Branch: master

commit bb9fd2c61a9ab41c57f427e13cd6a8bae391049e
Author: Steven Hardy <email address hidden>
Date: Thu Jan 11 13:14:50 2018 +0000

    Reinstate common overcloud manifest for all roles

    This was lost in the translation to ansible, but it's needed to
    enable existing interfaces such as hiera includes via *ExtraConfig.

    For reference this problem was introduced in:
    I674a4d9d2c77d1f6fbdb0996f6c9321848e32662 and this fix only considers
    returning the behaviour prior to that patch (for the baremetal puppet
    apply), further discussion is required on if/how this could be applied
    to the new container architecture.

    Change-Id: I0384edb23eed336b95ffe6293fe7d4248447e849
    Partial-Bug: #1742663