Failed to delete errored NS

[dharmendra]

Scenario:
While creating an NS(i.e. test_ns1), it failed to deploy VNFs due to some issues, and NS could not get VNF ids and NS went in Error state.

vagrant@control:/opt/stack/tacker/samples/tosca-templates/nsd$ tacker ns-list
+--------------------------------------+----------+--------------------------------------+------------------------------+--------+
| id | name | nsd_id | mgmt_urls | status |
+--------------------------------------+----------+--------------------------------------+------------------------------+--------+
| d75335d0-fc39-4328-b14b-2052b8b31661 | test_ns | 5ff0463c-f064-401e-9203-6747cd96c2ce | {'VNF2': None, 'VNF1': None} | ERROR |
| d99f2b09-bd50-4165-bc96-335edc66d2df | test_ns1 | 5ff0463c-f064-401e-9203-6747cd96c2ce | | ERROR |
+--------------------------------------+----------+--------------------------------------+------------------------------+--------+

Now while deleting errored NS, it failed with:------>

vagrant@control:/opt/stack/tacker/samples/tosca-templates/nsd$ tacker ns-delete d99f2b09-bd50-4165-bc96-335edc66d2df

Unable to delete the below ns(s):
 Cannot delete d99f2b09-bd50-4165-bc96-335edc66d2df: Request Failed: internal server error while processing your request.
vagrant@control:/opt/stack/tacker/samples/tosca-templates/nsd$

Logs are-------->

vagrant@control:/opt/stack/tacker/samples/tosca-templates/nsd$ tailf /opt/stack/logs/tacker-server.log
2018-01-09 12:07:07.696 7150 ERROR tacker.api.v1.resource wg.task(**kwargs)
2018-01-09 12:07:07.696 7150 ERROR tacker.api.v1.resource File "/opt/stack/tacker/tacker/nfvo/drivers/workflow/workflow_generator.py", line 148, in delete_vnf
2018-01-09 12:07:07.696 7150 ERROR tacker.api.v1.resource vnf_ids = ast.literal_eval(ns['vnf_ids'])
2018-01-09 12:07:07.696 7150 ERROR tacker.api.v1.resource File "/usr/lib/python2.7/ast.py", line 80, in literal_eval
2018-01-09 12:07:07.696 7150 ERROR tacker.api.v1.resource return _convert(node_or_string)
2018-01-09 12:07:07.696 7150 ERROR tacker.api.v1.resource File "/usr/lib/python2.7/ast.py", line 79, in _convert
2018-01-09 12:07:07.696 7150 ERROR tacker.api.v1.resource raise ValueError('malformed string')
2018-01-09 12:07:07.696 7150 ERROR tacker.api.v1.resource ValueError: malformed string
2018-01-09 12:07:07.696 7150 ERROR tacker.api.v1.resource
2018-01-09 12:07:07.707 INFO tacker.wsgi [req-dca7b3fa-d2aa-4b63-bd46-963b0839be77 admin admin] 10.0.2.15 - - [09/Jan/2018 12:07:07] "DELETE /v1.0/nss/d99f2b09-bd50-4165-bc96-335edc66d2df.json HTTP/1.1" 500 367 1.994887

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/532175

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/532175
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=733221bd600c2345feaedae996a85d748c41874c
Submitter: Zuul
Branch: master

commit 733221bd600c2345feaedae996a85d748c41874c
Author: dharmendra kushwaha <email address hidden>
Date: Tue Jan 9 12:35:36 2018 +0000

    In NS delete, proactively detect if no VNF exist.

    Proactively detect for VNFs in NS, if no vnf_ids exists, its
    meaningless to execute delete workflow.

    Change-Id: Iac66ed2c9fcb5c450c21270d8f843cf1f2bcd6ea
    Closes-Bug: #1742128

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tacker 0.9.0 release.