Copy Tag names not displayed in OPAC

[Jason Boyer]

Evergreen 3.0.2

When applying a copy tag such as "Donated By" my expectation is that the display would be similar to "Donated By: (Tag Value Here)" where instead only the "(Tag Value Here)" text is displayed to users in the OPAC. A lot of the value of copy tags (and a ton of search index space) would be lost if this is not the case.

[Remington Steed (rjs7)]

Here's a branch that fetches the data needed and adds it to the OPAC display.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/rsteed/lp1741980_opac_flesh_copy_tag_label

[Garry Collum (gcollum)]

Tested and works perfectly. Signoff branch is at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gcollum/lp1741980_opac_flesh_copy_tag_label-signoff

[Galen Charlton (gmc)]

The copy tag type was originally intended more for staff use, and I think there's at least one user of them that would be surprised if the type labels started displaying unexpectedly.

I don't object to the idea per se, but do think that the type label should be wrapped in a separate span with a "copy_tag_type_label" class or the like.

[Remington Steed (rjs7)]

Here's a branch with a second commit that does what Galen suggested. I've also included a release note to notify libraries about this change.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/rsteed/lp1741980_copy_tag_type_separate_span

[Kyle Huckins (khuckins)]

I have tested this code and consent to signing off on it with my name, Kyle Huckins and my email address, <email address hidden>.

[Galen Charlton (gmc)]

Pushed to master for inclusion in 3.4. Thanks, Remington, Garry, and Kyle!