Wrong/confuse text on shutdown at unattended-upgrades

[ITEAS]

[Impact]

 * The confusing text on shutdown is, well, can confuse users.
 * This fix itself is minor and would not warrant a backport but it is backported as part of fully backporting Bionic's u-u version to Xenial.

[Test Case]

 * Check that the status text is less confusing than it was previously either by configuring unattended-upgrades to run at shutdown and waiting for the text to appear or check that the text is changed in unattended-upgrades-shutdown:

$ grep -B1 please /usr/share/unattended-upgrades/unattended-upgrade-shutdown
    msg = _("Unattended-upgrade in progress during shutdown, "
            "please don't turn off the computer")

  * The former way or the verification may not be easy since with the fix for LP: #1803137 the shutdown screen does not show up when u-u-shutdown starts running, see the bug for the details.
  * Also checking unatttended-upgrades-shutdown for the changed text does not ensure that the translation is ready, too.

[Regression Potential]

 * The updated text should not cause major issues, but until it is translated to each language it is shown in English, possibly confusing users in a different way.

[Original Bug Text]

ProblemType: Bug
DistroRelease: Ubuntu 16.04
Package: unattended-upgrades-0.90ubuntu0.9
Uname: 4.4.0-104-generic #127-Ubuntu SMP
Architecture: amd64

I've german systems, so when updates will be installed at shutdown this text will be displayed at the screen.

German:
"unattended upgrade läuft während des herunterfahrens weiter, es wird fünf Sekunden lange gewartet"

English:
"unattended upgrade runs during the shutdown, it waits for five seconds"

This sentence make absolutly no sence for me. Maybe it is an translationproblem? Don't know text on the english ubuntuversion.
The problem is that some customer turned of some computers, because the updates need more time then 5 seconds ;)

A better message will that was Windows10 displays at shutdown ...don't turn off the computer, updates will be installed...

Thanks and best Reagards

[Hans Joachim Desserud (hjd)]

Thanks for taking your time to report this issue and help making Ubuntu better.

I found the original message, "Unattended-upgrade in progress during shutdown, sleeping for 5s" (https://translations.launchpad.net/ubuntu/artful/+source/unattended-upgrades/+pots/unattended-upgrades/de/52/+translate). Though I am not sure if the issue is with the translation or the original text.

When reporting bugs in the future please use apport by using 'ubuntu-bug' and the name of the package affected. You can learn more about this functionality at https://wiki.ubuntu.com/ReportingBugs.

[schuko24 (gerd-saenger)]

Translation changed to:
»Unattended-Upgrade läuft während des Herunterfahrens weiter, es beginnt in fünf Sekunden, Gerät bitte
nicht ausschalten.«

[ITEAS (info-tux-pc)]

Hello, and thanks for the fast reply :)

@Hans Joachim Desserud (hjd)
Thanks for the information. Never used Apport before. But looks likes easy too.

[ITEAS (info-tux-pc)]

@schuko24 (gerd-saenger) i think more better to understand:
»Automatische Systemupdates werden während des Herunterfahrens installiert. Der Vorgang kann einige Zeit dauern. Gerät bitte nicht ausschalten.«

Thanks a lot!

[Gunnar Hjalmarsson (gunnarhj)]

@schuko24: Please note that you didn't change the unattended-upgrades package; you changed the Launchpad translation for the package.

[ITEAS (info-tux-pc)]

Ok... so what is to do now that this text will be changed in german versions ubuntu 16.04 and up comming versions?

[schuko24 (gerd-saenger)]

@gunnarhj: Thanks for correcting, I just hit the wrong row with not being a programmer. Ooops.

[Gunnar Hjalmarsson (gunnarhj)]

On 2018-01-06 15:54, ITEAS wrote:
> Ok... so what is to do now that this text will be changed in german
> versions ubuntu 16.04 and up comming versions?

The change will affect 18.04 primarily. If another translation update of 16.04 is accomplished, the change will be seen there as well. 17.04 and 17.10 will probably not be changed.

[ITEAS (info-tux-pc)]

@gunnarhj Ok, thank you.

[Balint Reczey (rbalint)]

I proposed the fix at the packaging repository in https://github.com/mvo5/unattended-upgrades/pull/87 . Most likely it will be part of the next package update.

[Launchpad Janitor (janitor)]

This bug was fixed in the package unattended-upgrades - 0.99ubuntu2

---------------
unattended-upgrades (0.99ubuntu2) bionic; urgency=medium

  * Run upgrade-between-snapshots only on amd64.
    The test exercises only unattented-upgrade's Python code and uses
    dependencies from the frozen Debian snapshot archive thus running
    it on all architectures would provide little benefit.

 -- Balint Reczey <email address hidden> Tue, 13 Feb 2018 11:41:20 +0700

[Gunnar Hjalmarsson (gunnarhj)]

The new string is currently untranslated in most languages including German, but that's a regular condition and does not motivate a bug report. Dropping the Ubuntu Translations bug task.

[Brian Murray (brian-murray)]

Hello ITEAS, or anyone else affected,

Accepted unattended-upgrades into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/unattended-upgrades/1.1ubuntu1.18.04.7~16.04.0 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Łukasz Zemczak (sil2100)]

Hello ITEAS, or anyone else affected,

Accepted unattended-upgrades into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/unattended-upgrades/1.1ubuntu1.18.04.7~16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Balint Reczey (rbalint)]

Tested with 1.1ubuntu1.18.04.7~16.04.1:

root@x-uu-ref:~# dpkg -l unattended-upgrades | cat
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Architecture Description
+++-===================-==========================-============-===========================================
ii unattended-upgrades 1.1ubuntu1.18.04.7~16.04.1 all automatic installation of security upgrades
root@x-uu-ref:~# grep -B1 please /usr/share/unattended-upgrades/unattended-upgrade-shutdown
    msg = _("Unattended-upgrade in progress during shutdown, "
            "please don't turn off the computer")
--
            _("To enable monitoring the PrepareForShutdown() signal "
              "instead of polling please install the python3-gi package"))
root@x-uu-ref:~#

[ITEAS (info-tux-pc)]

Sorry for the late reply ;( I've not tested it on xenial, but on bionic it is working perfectly. Thanks a lot. Great work.

[Łukasz Zemczak (sil2100)]

Hello ITEAS, or anyone else affected,

Accepted unattended-upgrades into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/unattended-upgrades/1.1ubuntu1.18.04.7~16.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Balint Reczey (rbalint)]

Tested 1.1ubuntu1.18.04.7~16.04.2 on Xenial:

root@x-uu-verify:~# grep -B1 please /usr/share/unattended-upgrades/unattended-upgrade-shutdown
    msg = _("Unattended-upgrade in progress during shutdown, "
            "please don't turn off the computer")
--
            _("To enable monitoring the PrepareForShutdown() signal "
              "instead of polling please install the python3-gi package"))
root@x-uu-verify:~# dpkg -l unattended-upgrades | cat
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Architecture Description
+++-===================-==========================-============-===========================================
ii unattended-upgrades 1.1ubuntu1.18.04.7~16.04.2 all automatic installation of security upgrades

[Launchpad Janitor (janitor)]

This bug was fixed in the package unattended-upgrades - 1.1ubuntu1.18.04.7~16.04.2

---------------
unattended-upgrades (1.1ubuntu1.18.04.7~16.04.2) xenial; urgency=medium

  * Don't check blacklist too early and report updates from not allowed origins
    as kept back. (LP: #1781176)
  * test/test_blacklisted_wrong_origin.py: Fix and enable test
  * Filter out progress indicator from dpkg log (LP: #1599646)
  * Clear cache when autoremoval fails (LP: #1779157)
  * Find autoremovable kernel packages using the patterns in APT's way
    (LP: #1815494)

unattended-upgrades (1.1ubuntu1.18.04.7~16.04.1) xenial; urgency=medium

  * Start service after systemd-logind.service to be able to take inhibition
    lock (LP: #1806487)
  * Handle gracefully when logind is down (LP: #1806487)

unattended-upgrades (1.1ubuntu1.18.04.7~16.04.0) xenial; urgency=medium

  * Backport to Xenial (LP: #1702793)
  * Revert to build-depending on debhelper (>= 9~) and dh-systemd
  * Revert configuration example changes to avoid triggering a debconf question
  * debian/postinst: Update recovery to be triggered on Xenial's package versions

unattended-upgrades (1.1ubuntu1.18.04.7) bionic; urgency=medium

  * Trigger unattended-upgrade-shutdown actions with PrepareForShutdown()
    Performing upgrades in service's ExecStop did not work when the upgrades
    involved restarting services because systemd blocked other stop/start
    actions making maintainer scripts time out and be killed leaving a broken
    system behind.
    Running unattended-upgrades.service before shutdown.target as a oneshot
    service made it run after unmounting filesystems and scheduling services
    properly on shutdown is a complex problem and adding more services to the
    mix make it even more fragile.
    The solution of monitoring PrepareForShutdown() signal from DBus
    allows Unattended Upgrade to run _before_ the jobs related to shutdown are
    queued thus package upgrades can safely restart services without
    risking causing deadlocks or breaking part of the shutdown actions.
    Also ask running unattended-upgrades to stop when shutdown starts even in
    InstallOnShutdown mode and refactor most of unattended-upgrade-shutdown to
    UnattendedUpgradesShutdown class. (LP: #1778219)
  * Increase logind's InhibitDelayMaxSec to 30s. (LP: #1778219)
    This allows more time for unattended-upgrades to shut down gracefully
    or even install a few packages in InstallOnShutdown mode, but is still a
    big step back from the 30 minutes allowed for InstallOnShutdown previously.
    Users enabling InstallOnShutdown node are advised to increase
    InhibitDelayMaxSec even further possibly to 30 minutes.
    - Add NEWS entry about increasing InhibitDelayMaxSec and InstallOnShutdown
      changes
  * Ignore "W503 line break before binary operator"
    because it will become the best practice and breaks the build
  * Stop using ActionGroups, they interfere with apt.Cache.clear()
    causing all autoremovable packages to be handled as newly autoremovable
    ones and be removed by default. Dropping ActionGroup usage does not slow
    down the most frequent case of not having anything to upgrade a...