skin deere, button color red, 'knob_bg_red.svg' missing

Bug #1740582 reported by Stefan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
Stefan

Bug Description

just compiled branch 2.1, with last commit (https://github.com/mixxxdj/mixxx/commit/adf8d4bfe1e2a1bd6af69524cb04da1c78ddb598)

there on startup I got the following warning:

Warning [Main]: Cannot open file '/home/stefan/mixxx_master/mixxx/res/skins/Deere/knob_bg_red.svg', because: No such file or directory

In the file
https://github.com/mixxxdj/mixxx/blob/2.1/res/skins/Deere/tool_bar.xml

Line 60:

<Template src="skin:knob_toolbar.xml">
 <SetVariable name="TooltipId">headphone_gain</SetVariable>
 <SetVariable name="group">[Master]</SetVariable>
 <SetVariable name="control">headGain</SetVariable>
 <SetVariable name="color">red</SetVariable>
 <SetVariable name="label">Head</SetVariable>
</Template>

this calls
https://github.com/mixxxdj/mixxx/blob/2.1/res/skins/Deere/knob_toolbar.xml

Line 16:

<BackPath>knob_bg_<Variable name="color"/>.svg</BackPath>

which will be "knob_bg_red" in this case!

the same happens in

https://github.com/mixxxdj/mixxx/blob/2.1/res/skins/Deere/microphone.xml

Line 33:

<Template src="skin:knob_with_button.xml">
 <SetVariable name="TooltipId">microphone_pregain</SetVariable>
 <SetVariable name="control">pregain</SetVariable>
 <SetVariable name="color">red</SetVariable>
 <SetVariable name="button_TooltipId">mute</SetVariable>
 <SetVariable name="button_control">mute</SetVariable>
 <SetVariable name="label">Gain</SetVariable>
</Template>

calls knob_with_button.xml calls knob.xml

Line 14:

<BackPath>knob_bg_<Variable name="color"/>.svg</BackPath>

as well as
https://github.com/mixxxdj/mixxx/blob/2.1/res/skins/Deere/auxiliary.xml

Line 39
<Template src="skin:knob_with_button.xml">
 <SetVariable name="TooltipId">microphone_pregain</SetVariable>
 <SetVariable name="control">pregain</SetVariable>
 <SetVariable name="color">red</SetVariable>
 <SetVariable name="button_TooltipId">mute</SetVariable>
 <SetVariable name="button_control">mute</SetVariable>
 <SetVariable name="label">Gain</SetVariable>
</Template>

that's (in my opinion) the source of the warning!

Revision history for this message
Stefan (nopeppermint) wrote :
jus (jus)
Changed in mixxx:
assignee: nobody → Stefan (nopeppermint)
milestone: none → 2.1.0
importance: Undecided → Low
status: New → Fix Committed
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9037

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.