Validation: missing check for HostnameMap

[Cédric Jeanneret deactivated]

Dear Stackers,

When we use a static HostnameMap hash in an environment file, it would be great to have a validation that ensures we do not messed that hash.

In order to do so, it should ensure the uniqueness of tuples and ensure this kind of entries aren't present:
    overcloud-controller-0: controller-0
    overcloud-controller-1: controller-1
    overcloud-controller-2: controller-1 <- that one is wrong

Preventing users to make typo and errors in that hash will prevent breaking the whole heat stack when we want to add new nodes (computes, for example).

Thank you!

Cheers,

C.

[Cédric Jeanneret deactivated (cjeanneret-c2c-deactivated)]

Should affect https://github.com/openstack/tripleo-validations/tree/master/validations tree

but on that matter, I'm clueless, as I really don't know what to do… validations seem to be dedicated workflows described in yaml - checking the hash would require some kind of script language I guess… Any hint would be good :).

[Zane Bitter (zaneb)]

When people blacklist failed nodes they typically update the hostname map with dummy names like so:

    overcloud-compute-0: compute-0
    overcloud-compute-1: UNUSED
    overcloud-compute-2: UNUSED
    overcloud-compute-3: compute-3

Enforcing uniqueness at the parameter level in Heat (as https://review.openstack.org/#/c/530903/ seems to be preparing the ground for) will break existing deployments using this pattern.