tripleo

UCS ironic nodes collide on import

Bug #1739024 reported by Ilya Etingof
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Ilya Etingof
tripleo rocky-3

Bug Description

Importing multiple nodes configured to use pxe_ucs driver may end up importing just one of them. This happens when the nodes being imported only differ by the `pm_service_profile` value.

Steps to Reproduce
==================

1. import a ucs node
2. import another ucs node preserving `pm_addr` and `pm_port` values but having different `pm_service_profile` value
3. notice the new node takes the old ucs node's ironic uuid

Actual results
==============

New imported ironic nodes takes the same uuid of other ucs ironic node and changes name.

Expected results
================

Two distinct ironic nodes added

Environment
===========

OpenStack 10 Newton

Ilya Etingof (etingof)
Changed in tripleo:
assignee: nobody → Ilya Etingof (etingof)
status: New → Confirmed
affects: tripleo → tripleo-common
Alex Schultz (alex-schultz)
affects: tripleo-common → tripleo
Changed in tripleo:
importance: Undecided → Medium
milestone: none → queens-3
OpenStack Infra (hudson-openstack)
Changed in tripleo:
status: Confirmed → In Progress
Emilien Macchi (emilienm)
Changed in tripleo:
milestone: queens-3 → queens-rc1
Alex Schultz (alex-schultz)
Changed in tripleo:
milestone: queens-rc1 → rocky-1
Alex Schultz (alex-schultz)
Changed in tripleo:
milestone: rocky-1 → rocky-2
Emilien Macchi (emilienm)
Changed in tripleo:
milestone: rocky-2 → rocky-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-common (master)

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/528726
Reason: The gate is suffering of timeouts, we need to clear it. Please do not restore or recheck this patch, I'll take care of it when gate is stable again.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/528726
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=ea50e58eb6c4d0aab9d79a531a3644fd136993c5
Submitter: Zuul
Branch: master

commit ea50e58eb6c4d0aab9d79a531a3644fd136993c5
Author: Ilya Etingof <email address hidden>
Date: Mon Dec 18 14:40:17 2017 +0100

    ensure unique ironic node ID with UCS driver

    The UCS driver info handling is split off the common
    PrefixedDriverInfo implementation for the purpose of
    generating unique node IDs in a driver-specific and
    clean way.

    This change un-deprecates `pm_service_profile` option
    support.

    Closes-Bug: #1739024
    Change-Id: Ibabe216d3e2b1ea33adc1feaae7095e76cfad19d

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/583985

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 9.2.0

This issue was fixed in the openstack/tripleo-common 9.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/queens)

Reviewed: https://review.openstack.org/583985
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=17e786f83aacd7994e1071835c62e91c49febc79
Submitter: Zuul
Branch: stable/queens

commit 17e786f83aacd7994e1071835c62e91c49febc79
Author: Ilya Etingof <email address hidden>
Date: Mon Dec 18 14:40:17 2017 +0100

    ensure unique ironic node ID with UCS driver

    The UCS driver info handling is split off the common
    PrefixedDriverInfo implementation for the purpose of
    generating unique node IDs in a driver-specific and
    clean way.

    This change un-deprecates `pm_service_profile` option
    support.

    Conflicts: tripleo_common/utils/nodes.py

    Closes-Bug: #1739024
    Change-Id: Ibabe216d3e2b1ea33adc1feaae7095e76cfad19d
    (cherry picked from commit ea50e58eb6c4d0aab9d79a531a3644fd136993c5)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 8.6.4

This issue was fixed in the openstack/tripleo-common 8.6.4 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/591766

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/pike)

Reviewed: https://review.openstack.org/591766
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=65bb298f9f3d74bdcd5578c85435a75542daf5a5
Submitter: Zuul
Branch: stable/pike

commit 65bb298f9f3d74bdcd5578c85435a75542daf5a5
Author: Ilya Etingof <email address hidden>
Date: Mon Dec 18 14:40:17 2017 +0100

    ensure unique ironic node ID with UCS driver

    The UCS driver info handling is split off the common
    PrefixedDriverInfo implementation for the purpose of
    generating unique node IDs in a driver-specific and
    clean way.

    This change un-deprecates `pm_service_profile` option
    support.

    Conflicts: tripleo_common/utils/nodes.py

    Closes-Bug: #1739024
    Change-Id: Ibabe216d3e2b1ea33adc1feaae7095e76cfad19d
    (cherry picked from commit ea50e58eb6c4d0aab9d79a531a3644fd136993c5)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 7.6.16

This issue was fixed in the openstack/tripleo-common 7.6.16 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.