"overcloud container image upload" uploads images already at the destination

[Steve Baker]

If the upload command could skip images which are already at the destination, it could be fast enough to run as an action during every deployment workflow, which would remove the need to document a separate upload step.

The check would need to compare the source and destination checksums, just in case a tag is pointed to a different image.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/531274

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/531274
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=18a1349a772b0a3f7dfceb06570c9da1f875ca72
Submitter: Zuul
Branch: master

commit 18a1349a772b0a3f7dfceb06570c9da1f875ca72
Author: Steve Baker <email address hidden>
Date: Fri Jan 5 13:59:36 2018 +1300

    Skip unnecessary image uploads

    This modifies the container image upload to avoid doing an upload when
    the destination image already exists and is identical to the source
    image.

    This is done by doing a skopeo inspect on the source and destination
    images and compares their digest hash.

    In RDO Cloud, a full upload takes around 8 minutes. With this change
    and an already populated local registry it takes less than 10 seconds.
    The extra 2 skopeo inspect calls per upload doesn't measurably impact
    the full upload time.

    This makes the upload fast enough to run within the main deploy
    workflow on every run (which will take more work because the upload
    yaml file needs to be stored in the plan).

    Change-Id: Ic9422b0ca168b4405cb1973f4e33c91b0f69f02c
    Closes-Bug: #1738668

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 8.4.0 release.