ProcessTemplatesAction._heat_resource_exists is inneficient

Bug #1738208 reported by Thomas Herve
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Emilien Macchi

Bug Description

It uses listing to retrieving one resource, we should be able to do better. It's also used for a single case where we know where the resource should be, so we can simply use resource show while it's not used anywhere else.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/528006

Changed in tripleo:
assignee: nobody → Thomas Herve (therve)
status: New → In Progress
Changed in tripleo:
importance: Undecided → Medium
milestone: none → queens-3
Changed in tripleo:
assignee: Thomas Herve (therve) → Emilien Macchi (emilienm)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/528006
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=1b6e723dbbfec1afdafdf5a30b24d70f9447ab43
Submitter: Zuul
Branch: master

commit 1b6e723dbbfec1afdafdf5a30b24d70f9447ab43
Author: Thomas Herve <email address hidden>
Date: Thu Dec 14 17:17:06 2017 +0100

    Optimize _heat_resource_exists

    Replace stack resource list with 2 resource show calls to find if a
    resource exists.

    Change-Id: I6f9d4e43e183273e95efda4002c87e766afc7301
    Closes-Bug: #1738208

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 8.3.0

This issue was fixed in the openstack/tripleo-common 8.3.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.