docker-puppet.py time handling is hard to debug

[Jiří Stránský]

We seem to be sometimes hitting an issue where puppet containers seem to think that /etc/hosts was modified and they try to copy it among the puppet-generated files. This has been originally reported as bug 1709689. It may be easier to debug if we know what mtime was on the_origin_of_time file, and if we mounted /etc/localtime into the container to sync the timezone info between host and container.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/527673

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/527673
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=51a3b05f4ec952d99935fdbbc64347c0404fd29b
Submitter: Zuul
Branch: master

commit 51a3b05f4ec952d99935fdbbc64347c0404fd29b
Author: Jiri Stransky <email address hidden>
Date: Wed Dec 13 12:33:37 2017 +0100

    Improve debugging possibilities for docker-puppet.py time handling

    We faced issue where on some environments docker-puppet.py picks up
    /etc/hosts as modified, even though that shouldn't be the case (LP bug
    1709689). On the last occasion we found the cause to be desynced time
    on the host machine of a virtual setup, and subsequent NTP sync of
    overcloud nodes (causing a 5 hour skip back in time) racing with
    docker-puppet.py.

    Still, more info to debug these kinds of issues would be nice to
    have. Printing the timestamp of origin_of_time, saving it to a
    persistent directory and making sure /etc/localtime is mounted into
    docker-puppet containers should make finding the root cause on such
    occasions easier.

    Change-Id: I2ea197673b470379ead295058b6952cce3a69606
    Closes-Bug: #1737954

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/543510

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/543510
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=9d44e267b8341b40040835b5e4b987930499bc72
Submitter: Zuul
Branch: stable/pike

commit 9d44e267b8341b40040835b5e4b987930499bc72
Author: Jiri Stransky <email address hidden>
Date: Wed Dec 13 12:33:37 2017 +0100

    Improve debugging possibilities for docker-puppet.py time handling

    We faced issue where on some environments docker-puppet.py picks up
    /etc/hosts as modified, even though that shouldn't be the case (LP bug
    1709689). On the last occasion we found the cause to be desynced time
    on the host machine of a virtual setup, and subsequent NTP sync of
    overcloud nodes (causing a 5 hour skip back in time) racing with
    docker-puppet.py.

    Still, more info to debug these kinds of issues would be nice to
    have. Printing the timestamp of origin_of_time, saving it to a
    persistent directory and making sure /etc/localtime is mounted into
    docker-puppet containers should make finding the root cause on such
    occasions easier.

    Change-Id: I2ea197673b470379ead295058b6952cce3a69606
    Closes-Bug: #1737954
    (cherry picked from commit 51a3b05f4ec952d99935fdbbc64347c0404fd29b)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.10 release.