'm_curFrameIndex': undeclared identifier

[Jordi]

I get undeclared identifier errors for the variable "m_curFrameIndex" in plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp when compiling Mixxx in debug mode.

These are the lines of code that cause the errors:
DEBUG_ASSERT(m_curFrameIndex == firstFrameIndex);
DEBUG_ASSERT(isValidFrameIndex(m_curFrameIndex));

The error only occurs in debug mode because DEBUG_ASSERT does not do anything in release builds, as we see here: https://github.com/mixxxdj/mixxx/blob/master/src/util/assert.h#L57

I think that it is just a typo and "m_curFrameIndex" should be renamed to "m_currentFrameIndex".

Machine info:
OS: Windows 10
CPU: Intel(R) Core(TM) i7-7660U CPU @ 2.5Ghz

Steps to reproduce the error:
 1. Compile Mixxx in debug mode (compile Mixxx passing build=debug argument to scons)

These are the exact errors:
  plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(262): error C2065: 'm_curFrameIndex':
  undeclared identifier
  plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(462): error C2065: 'm_curFrameIndex':
  undeclared identifier

[Uwe Klotz (uklotzde-deactivatedaccount)]

Thanks! I didn't notice this error when compiling remotely on AppVeyor.

[Uwe Klotz (uklotzde-deactivatedaccount)]

https://github.com/mixxxdj/mixxx/pull/1410

It would be really helpful if you could help testing M4A playback with assertions enabled on Windows. I hope that I didn't miss anything when porting the SoundSourceMediaFoundation plugin to the new API version.

[Jordi (jordi665)]

Sure, I will test M4A playback this weekend.

[Uwe Klotz (uklotzde-deactivatedaccount)]

https://github.com/mixxxdj/mixxx/pull/1410

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9002