Web Client: Pending Patrons No Delete

[Scott Thomas]

In the Web Client at 3.0, the Pending Patron feature does not contain a Delete option. Only Load is present. Our libraries delete pending patrons whom they opt not to load due to various issues with the information provided by the patron.

[Andrea Neiman (aneiman)]

Confirmed on 3.0.1

[Heather Lindskold (heatherlindskold)]

Just wanted to confirm that this is affecting us in 3.0.7. We can go into XUL and remove pending patrons but there does not seem to be a way to do it in webby.

[Blake GH (bmagic)]

+1 3.0.9

[Meg Stroup (mstroup)]

Confirming that this affects us in 3.1.5. We were able to delete in XUL, but that function is missing in the web client.

[Cesar V (cesardv)]

I've added a "Delete Pending Patron(s)" grid button, see branch here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/cesardv/lp1737800-add-delete-btn-pending-patrons-grid

[Terran McCanna (tmccanna)]

Tested in 3.2.2 and it worked great for me! Thank you, Cesar!

I have tested this code and consent to signing off on it with my name, Terran McCanna, and my email address, <email address hidden>.

[Bill Erickson (berick)]

Cesar, could you please post another commit with the following changes:

1. Add your sign-off

2. Change
    $q.all(promises).then(refresh_page());
to
    $q.all(promises).then(refresh_page);

This way the refresh_page function is not called until after the promises are complete. Alternatively, wrap it up like .then(function() { refresh_page() });

[Cesar V (cesardv)]

Hi Bill, good catch! Thanks for testing this. I've amended the original branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/cesardv/lp1737800-add-delete-btn-pending-patrons-grid

[Bill Erickson (berick)]

Thanks Cesar. Thanks Terran.

Re-tested new branch and merged to master / 3.2.