clicking iTunes feature in library pops up annoying dialog

[Be]

Clicking the iTunes feature in the library pops up a dialog asking to select the iTunes library location. This is unexpected and annoying. It is easy to accidentally have this dialog interrupt use of Mixxx when exploring Mixxx's features.

[anurag (iamanurag)]

i wish to pick this issue , need some help (new in community)

- OS specification (if any)
- references to start

[Daniel Schürmann (daschuer)]

Cool, thank you very much.

A good start to read is:
https://www.mixxx.org/wiki/doku.php/bugfix_workflow

The dialog of question is located here:
https://github.com/mixxxdj/mixxx/blob/5aa13a5c47f8fd9913e69c10af9080030fa05b30/src/library/itunes/itunesfeature.cpp#L207

The preferences option is here:
https://github.com/mixxxdj/mixxx/blob/43e44628593acf2bd0d81ffc19b2946c0ec5a64b/src/preferences/dialog/dlgpreflibrary.cpp#L164

What do you plan to do?

[anurag (iamanurag)]

I think there is some duplication or non re-initialization of some statement due to which such error is occurring. Will post as soon as i find it out .

[anurag (iamanurag)]

Can someone please help me locate the functions called because it doesn't look like there is any error in definition ?

[Be (be.ing)]

I think you are misunderstanding the issue here. There is not an error occurring here. The problem is a usability issue. An unsuspecting user who clicks on the iTunes feature will have a dialog pop up and interrupt their use of Mixxx. Perhaps enabling the option to show the iTunes library in the preferences should require locating the iTunes library. Otherwise, if the user does not select a valid iTunes library location, the iTunes feature should not be shown in the library.

[anurag (iamanurag)]

As far as I have understood it, the issue states that an unwanted pop up flashes on screen as soon as we click on iTunes option . Correct ?

[Be (be.ing)]

Yes, and that popup needs to be shown at some point for the iTunes feature to work. The problem is that it is shown at a time when it is not expected and is likely to interrupt use of Mixxx.

[anurag (iamanurag)]

So thats what i wish to know, in which file have the functions being called ? Like in src/library/itunes/...... the object itunes is defined but where is it actually used ?

[Daniel Schürmann (daschuer)]

Which IDE are you using on which OS?
Normally this should help you to navigate through the code.
Did you follow the wiki link above?
A quick fix would be to disable the iTunes feature if the user does not give a valid folder after the first pop up.
Something like a second pop up
"No ITumes library found. The iTunes feature will be disabled an can be reanabled in Library preferences'

[anurag (iamanurag)]

1. I am currently using scons to compile on ubuntu 16(as mentioned in the documentation) .
2. What does milestone means ?
3. The references mentioned above are for the constructors not their implementation.

[anurag (iamanurag)]

Ok error i found is in this line

https://github.com/mixxxdj/mixxx/blob/5aa13a5c47f8fd9913e69c10af9080030fa05b30/src/library/itunes/itunesfeature.cpp#L116

commending it stops pop ups

but choosing option "Use default library" in itunes load the library from the path stored in variable rather than opening a widget and ask for a file ?

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9001