Hostname validation for undercloud is too strict

[wes hayutin]

Hostname validation for undercloud is too strict:

2017-12-21 10:47:02 | + openstack undercloud install
2017-12-21 10:47:03 | 2017-12-21 10:47:03,579 INFO: Logging to /home/jenkins/.instack/install-undercloud.log
2017-12-21 10:47:03 | 2017-12-21 10:47:03,601 INFO: Checking for a FQDN hostname...
2017-12-21 10:47:03 | 2017-12-21 10:47:03,634 INFO: Static hostname detected as undercloud
2017-12-21 10:47:03 | 2017-12-21 10:47:03,643 INFO: Transient hostname detected as undercloud
2017-12-21 10:47:03 | 2017-12-21 10:47:03,644 ERROR: An error occurred during configuration validation, please check your host configuration and try again. Error message: Configured hostname is not fully qualified.
2017-12-21 10:47:03 | Command 'instack-install-undercloud' returned non-zero exit status 1

The validation checks that the hostname (fully qualified or not) is present in the /etc/hosts file and adds it to /etc/hosts otherwise.

However the _check_hostname() function raises an exception if it tries to write the hostname to /etc/hosts and it is not fully qualified.

None of the CI runs I've observed have a fully qualified hostname, and the validation succeeds only because the hostname is already present in /etc/hosts.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/529548

[OpenStack Infra (hudson-openstack)]

Change abandoned by Martin André (<email address hidden>) on branch: master
Review: https://review.openstack.org/529548

[Matt Young (halcyondude)]

update - the first run of rhos-13 TQ gates was attempting and ran headlong into this..

https://thirdparty.logs.rdoproject.org/jenkins-tq-gate-rhos-13-ci-rhos-ovb-minimal-pacemaker-public-bond-1/undercloud/home/stack/undercloud_install.log.txt.gz

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/567520

[OpenStack Infra (hudson-openstack)]

Change abandoned by Bogdan Dobrelya (<email address hidden>) on branch: master
Review: https://review.openstack.org/567520

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alex Schultz (<email address hidden>) on branch: master
Review: https://review.openstack.org/525286
Reason: Abandoning this patch per the TripleO Patch Abandonment guidelines (https://specs.openstack.org/openstack/tripleo-specs/specs/policy/patch-abandonment.html). If you wish to have this restored and cannot do so yourself, please reach out via #tripleo on freenode or the OpenStack Dev mailing list.