volume attach fail with reserved status

[Rico Lin]

Find error in http://logs.openstack.org/39/526339/2/check/heat-functional-convg-mysql-lbaasv2/d16da54/job-output.txt.gz#_2017-12-09_05_24_10_910679

Cinder attach will change to use `reserved` as status before actually start attaching.
so we failed with `reserved` here which we shouldn't.

Dec 09 05:19:37.070872 ubuntu-xenial-inap-mtl01-0001336704 heat-engine[22190]: INFO heat.engine.resource [None req-30291983-328c-47d0-aa94-a0995fbb022c demo None] CREATE: CinderVolumeAttachment "vol_att" [e8e3b25e-97e0-4d8f-ba2a-e96c061fa2a2] Stack "BasicResourcesTest-1656268858" [16843103-838e-4eb5-94bc-2da813cc2c6b]
Dec 09 05:19:37.071267 ubuntu-xenial-inap-mtl01-0001336704 heat-engine[22190]: 2017-12-09 05:19:37.065 23657 TRACE heat.engine.resource Traceback (most recent call last):
Dec 09 05:19:37.071767 ubuntu-xenial-inap-mtl01-0001336704 heat-engine[22190]: 2017-12-09 05:19:37.065 23657 TRACE heat.engine.resource File "/opt/stack/new/heat/heat/engine/resource.py", line 891, in _action_recorder
Dec 09 05:19:37.072347 ubuntu-xenial-inap-mtl01-0001336704 heat-engine[22190]: 2017-12-09 05:19:37.065 23657 TRACE heat.engine.resource yield
Dec 09 05:19:37.072665 ubuntu-xenial-inap-mtl01-0001336704 heat-engine[22190]: 2017-12-09 05:19:37.065 23657 TRACE heat.engine.resource File "/opt/stack/new/heat/heat/engine/resource.py", line 999, in _do_action
Dec 09 05:19:37.073238 ubuntu-xenial-inap-mtl01-0001336704 heat-engine[22190]: 2017-12-09 05:19:37.065 23657 TRACE heat.engine.resource yield self.action_handler_task(action, args=handler_args)
Dec 09 05:19:37.073474 ubuntu-xenial-inap-mtl01-0001336704 heat-engine[22190]: 2017-12-09 05:19:37.065 23657 TRACE heat.engine.resource File "/opt/stack/new/heat/heat/engine/scheduler.py", line 346, in wrapper
Dec 09 05:19:37.073706 ubuntu-xenial-inap-mtl01-0001336704 heat-engine[22190]: 2017-12-09 05:19:37.065 23657 TRACE heat.engine.resource step = next(subtask)
Dec 09 05:19:37.073938 ubuntu-xenial-inap-mtl01-0001336704 heat-engine[22190]: 2017-12-09 05:19:37.065 23657 TRACE heat.engine.resource File "/opt/stack/new/heat/heat/engine/resource.py", line 950, in action_handler_task
Dec 09 05:19:37.074600 ubuntu-xenial-inap-mtl01-0001336704 heat-engine[22190]: 2017-12-09 05:19:37.065 23657 TRACE heat.engine.resource done = check(handler_data)
Dec 09 05:19:37.074823 ubuntu-xenial-inap-mtl01-0001336704 heat-engine[22190]: 2017-12-09 05:19:37.065 23657 TRACE heat.engine.resource File "/opt/stack/new/heat/heat/engine/resources/volume_base.py", line 192, in check_create_complete
Dec 09 05:19:37.075041 ubuntu-xenial-inap-mtl01-0001336704 heat-engine[22190]: 2017-12-09 05:19:37.065 23657 TRACE heat.engine.resource return self.client_plugin().check_attach_volume_complete(volume_id)
Dec 09 05:19:37.075261 ubuntu-xenial-inap-mtl01-0001336704 heat-engine[22190]: 2017-12-09 05:19:37.065 23657 TRACE heat.engine.resource File "/opt/stack/new/heat/heat/engine/clients/os/cinder.py", line 169, in check_attach_volume_complete
Dec 09 05:19:37.075486 ubuntu-xenial-inap-mtl01-0001336704 heat-engine[22190]: 2017-12-09 05:19:37.065 23657 TRACE heat.engine.resource result=_('Volume attachment failed'))
Dec 09 05:19:37.075707 ubuntu-xenial-inap-mtl01-0001336704 heat-engine[22190]: 2017-12-09 05:19:37.065 23657 TRACE heat.engine.resource ResourceUnknownStatus: Volume attachment failed - Unknown status reserved due to "Unknown"
Dec 09 05:19:37.075951 ubuntu-xenial-inap-mtl01-0001336704 heat-engine[22190]: 2017-12-09 05:19:37.065 23657 TRACE heat.engine.resource
Dec 09 05:19:37.082782 ubuntu-xenial-inap-mtl01-0001336704 heat-engine[22190]: INFO heat.engine.stack [None req-30291983-328c-47d0-aa94-a0995fbb022c demo None] Stack CREATE FAILED (BasicResourcesTest-1656268858): Resource CREATE failed: ResourceUnknownStatus: resources.vol_att: Volume attachment failed - Unknown status reserved due to "Unknown"

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/526867
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=81a2e4ab4358a5d97ca65e3c6ce32dbd3a75f243
Submitter: Zuul
Branch: master

commit 81a2e4ab4358a5d97ca65e3c6ce32dbd3a75f243
Author: ricolin <email address hidden>
Date: Sun Dec 10 00:45:31 2017 +0800

    Allow reserved status for attach check

    This issue was due to Nova changes it's volume attach workflow
    (https://review.openstack.org/#/c/330285) which allows `reserved`
    status.
    Closes-Bug: #1737343

    Change-Id: I13f1906f53a89586bb51c0b70fa768a9500dfa26

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat 10.0.0.0b3 development milestone.