tripleo-ui package fails to build in DLRN in "npm run build"

[wes hayutin]

This is causing failures in the oooq check gates in ci.centos

[root@localhost 50ac25bcd1b84a90f882fbf75536fd902e8a0a3f_dev]# cat build.log
Mock Version: 1.2.17
Mock Version: 1.2.17
Mock Version: 1.2.17
Mock Version: 1.2.17
ENTER ['do'](['bash', '--login', '-c', '/usr/bin/rpmbuild -bs --target x86_64 --nodeps /builddir/build/SPECS/openstack-tripleo-ui.spec'], chrootPath='/var/lib/mock/dlrn-centos7-x86_64-1/root'shell=FalseprintOutput=Falseenv={'LANG': 'en_US.UTF-8', 'TERM': 'vt100', 'SHELL': '/bin/bash', 'PROMPT_COMMAND': 'printf "\x1b]0;<mock-chroot>\x07<mock-chroot>"', 'PATH': '/usr/bin:/bin:/usr/sbin:/sbin', 'HOME': '/builddir', 'HOSTNAME': 'mock'}gid=135user='mockbuild'timeout=0logger=<mockbuild.trace_decorator.getLog object at 0x28a01d0>uid=1002)
Executing command: ['bash', '--login', '-c', '/usr/bin/rpmbuild -bs --target x86_64 --nodeps /builddir/build/SPECS/openstack-tripleo-ui.spec'] with env {'LANG': 'en_US.UTF-8', 'TERM': 'vt100', 'SHELL': '/bin/bash', 'PROMPT_COMMAND': 'printf "\x1b]0;<mock-chroot>\x07<mock-chroot>"', 'PATH': '/usr/bin:/bin:/usr/sbin:/sbin', 'HOME': '/builddir', 'HOSTNAME': 'mock'} and shell False
DEBUG: Unsharing. Flags: 134217728
Building target platforms: x86_64
Building for target x86_64
Wrote: /builddir/build/SRPMS/openstack-tripleo-ui-8.1.1-0.20171209154238.50ac25b.el7.centos.src.rpm
Child return code was: 0
Mock Version: 1.2.17
ENTER ['do'](['bash', '--login', '-c', '/usr/bin/rpmbuild -bs --target x86_64 --nodeps /builddir/build/SPECS/openstack-tripleo-ui.spec'], chrootPath='/var/lib/mock/dlrn-centos7-x86_64-1/root'shell=FalseprintOutput=Falseenv={'LANG': 'en_US.UTF-8', 'TERM': 'vt100', 'SHELL': '/bin/bash', 'PROMPT_COMMAND': 'printf "\x1b]0;<mock-chroot>\x07<mock-chroot>"', 'PATH': '/usr/bin:/bin:/usr/sbin:/sbin', 'HOME': '/builddir', 'HOSTNAME': 'mock'}gid=135user='mockbuild'timeout=0logger=<mockbuild.trace_decorator.getLog object at 0x13bd150>uid=1002)
Executing command: ['bash', '--login', '-c', '/usr/bin/rpmbuild -bs --target x86_64 --nodeps /builddir/build/SPECS/openstack-tripleo-ui.spec'] with env {'LANG': 'en_US.UTF-8', 'TERM': 'vt100', 'SHELL': '/bin/bash', 'PROMPT_COMMAND': 'printf "\x1b]0;<mock-chroot>\x07<mock-chroot>"', 'PATH': '/usr/bin:/bin:/usr/sbin:/sbin', 'HOME': '/builddir', 'HOSTNAME': 'mock'} and shell False
DEBUG: Unsharing. Flags: 134217728
Building target platforms: x86_64
Building for target x86_64
Wrote: /builddir/build/SRPMS/openstack-tripleo-ui-8.1.1-0.20171209154238.50ac25b.el7.centos.src.rpm
Child return code was: 0
ENTER ['do'](['bash', '--login', '-c', u'/usr/bin/rpmbuild -bb --target x86_64 --nodeps /builddir/build/SPECS/openstack-tripleo-ui.spec'], chrootPath='/var/lib/mock/dlrn-centos7-x86_64-1/root'shell=Falseuid=1002env={'LANG': 'en_US.UTF-8', 'TERM': 'vt100', 'SHELL': '/bin/bash', 'PROMPT_COMMAND': 'printf "\x1b]0;<mock-chroot>\x07<mock-chroot>"', 'PATH': '/usr/bin:/bin:/usr/sbin:/sbin', 'HOME': '/builddir', 'HOSTNAME': 'mock'}gid=135user='mockbuild'timeout=0private_network=Truelogger=<mockbuild.trace_decorator.getLog object at 0x13bd150>printOutput=False)
Executing command: ['bash', '--login', '-c', u'/usr/bin/rpmbuild -bb --target x86_64 --nodeps /builddir/build/SPECS/openstack-tripleo-ui.spec'] with env {'LANG': 'en_US.UTF-8', 'TERM': 'vt100', 'SHELL': '/bin/bash', 'PROMPT_COMMAND': 'printf "\x1b]0;<mock-chroot>\x07<mock-chroot>"', 'PATH': '/usr/bin:/bin:/usr/sbin:/sbin', 'HOME': '/builddir', 'HOSTNAME': 'mock'} and shell False
DEBUG: Unsharing. Flags: 134217728
Building target platforms: x86_64
Building for target x86_64
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.orKTUl
+ umask 022
+ cd /builddir/build/BUILD
+ cd /builddir/build/BUILD
+ rm -rf tripleo-ui-8.1.1.dev10
+ /usr/bin/gzip -dc /builddir/build/SOURCES/tripleo-ui-8.1.1.dev10-0.20171209154238.50ac25b.tar.gz
+ /usr/bin/tar -xf -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd tripleo-ui-8.1.1.dev10
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ /usr/bin/git init -q
+ /usr/bin/git config user.name rpm-build
+ /usr/bin/git config user.email '<rpm-build>'
+ /usr/bin/git add .
+ /usr/bin/git commit -q -a --author 'rpm-build <rpm-build>' -m 'openstack-tripleo-ui-8.1.1 base'
+ exit 0
Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.tDZKi5
+ umask 022
+ cd /builddir/build/BUILD
+ cd tripleo-ui-8.1.1.dev10
+ rm -rf node_modules
+ ln -s /opt/openstack-tripleo-ui-deps/node_modules .
+ npm run build
> tripleo-ui@8.1.0 build /builddir/build/BUILD/tripleo-ui-8.1.1.dev10
> webpack --env=prod --bail --progress
  0% compiling/opt/openstack-tripleo-ui-deps/node_modules/cheerio/lib/api/traversing.js:10
    return memo.concat(_.filter(elem.children, isTag));
                                    ^
TypeError: Cannot read property 'children' of undefined
    at /opt/openstack-tripleo-ui-deps/node_modules/cheerio/lib/api/traversing.js:10:37
    at /opt/openstack-tripleo-ui-deps/node_modules/lodash/lodash.js:935:11
    at /opt/openstack-tripleo-ui-deps/node_modules/lodash/lodash.js:4920:15
    at baseReduce (/opt/openstack-tripleo-ui-deps/node_modules/lodash/lodash.js:932:5)
    at Function.reduce (/opt/openstack-tripleo-ui-deps/node_modules/lodash/lodash.js:9698:14)
    at initialize.exports.find (/opt/openstack-tripleo-ui-deps/node_modules/cheerio/lib/api/traversing.js:9:17)
    at initialize.module.exports (/opt/openstack-tripleo-ui-deps/node_modules/cheerio/lib/cheerio.js:86:18)
    at new initialize (/opt/openstack-tripleo-ui-deps/node_modules/cheerio/lib/static.js:26:20)
    at initialize (/opt/openstack-tripleo-ui-deps/node_modules/cheerio/lib/static.js:23:14)
    at Object.parse (/opt/openstack-tripleo-ui-deps/node_modules/favicons/helpers-es5.js:193:39)
    at /opt/openstack-tripleo-ui-deps/node_modules/favicons/es5.js:84:31
    at Object.async.forEachOf.async.eachOf (/opt/openstack-tripleo-ui-deps/node_modules/async/lib/async.js:233:13)
    at createHTML (/opt/openstack-tripleo-ui-deps/node_modules/favicons/es5.js:83:19)
    at /opt/openstack-tripleo-ui-deps/node_modules/favicons/es5.js:122:24
    at /opt/openstack-tripleo-ui-deps/node_modules/async/lib/async.js:718:13
    at async.forEachOf.async.eachOf (/opt/openstack-tripleo-ui-deps/node_modules/async/lib/async.js:233:13)
    at _parallel (/opt/openstack-tripleo-ui-deps/node_modules/async/lib/async.js:717:9)
    at Object.async.parallel (/opt/openstack-tripleo-ui-deps/node_modules/async/lib/async.js:731:9)
    at createPlatform (/opt/openstack-tripleo-ui-deps/node_modules/favicons/es5.js:117:19)
    at /opt/openstack-tripleo-ui-deps/node_modules/favicons/es5.js:135:21
    at Object.async.forEachOf.async.eachOf (/opt/openstack-tripleo-ui-deps/node_modules/async/lib/async.js:233:13)
    at createOffline (/opt/openstack-tripleo-ui-deps/node_modules/favicons/es5.js:131:19)
    at create (/opt/openstack-tripleo-ui-deps/node_modules/favicons/es5.js:178:90)
    at /opt/openstack-tripleo-ui-deps/node_modules/favicons/es5.js:184:20
    at fn (/opt/openstack-tripleo-ui-deps/node_modules/async/lib/async.js:746:34)
    at /opt/openstack-tripleo-ui-deps/node_modules/async/lib/async.js:1213:16
    at /opt/openstack-tripleo-ui-deps/node_modules/async/lib/async.js:166:37
    at /opt/openstack-tripleo-ui-deps/node_modules/async/lib/async.js:706:43
    at /opt/openstack-tripleo-ui-deps/node_modules/async/lib/async.js:167:37
    at Immediate.<anonymous> (/opt/openstack-tripleo-ui-deps/node_modules/async/lib/async.js:1206:34)
npm ERR! Linux 3.10.0-693.2.2.el7.x86_64
npm ERR! argv "/usr/bin/node" "/usr/bin/npm" "run" "build"
npm ERR! node v6.10.2
npm ERR! npm v3.10.10
npm ERR! code ELIFECYCLE
npm ERR! tripleo-ui@8.1.0 build: `webpack --env=prod --bail --progress`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the tripleo-ui@8.1.0 build script 'webpack --env=prod --bail --progress'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the tripleo-ui package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! webpack --env=prod --bail --progress
npm ERR! You can get information on how to open an issue for this project with:
npm ERR! npm bugs tripleo-ui
npm ERR! Or if that isn't available, you can get their info via:
npm ERR! npm owner ls tripleo-ui
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR! /builddir/build/BUILD/tripleo-ui-8.1.1.dev10/npm-debug.log
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.tDZKi5 (%build)
    Bad exit status from /var/tmp/rpm-tmp.tDZKi5 (%build)
Child return code was: 1
EXCEPTION: [Error()]
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 88, in trace
    result = func(*args, **kw)
  File "/usr/lib/python2.7/site-packages/mockbuild/util.py", line 547, in do
    raise exception.Error("Command failed. See logs for output.\n # %s" % (command,), child.returncode)
Error: Command failed. See logs for output.
 # bash --login -c /usr/bin/rpmbuild -bb --target x86_64 --nodeps /builddir/build/SPECS/openstack-tripleo-ui.spec
[root@localhost 50ac25bcd1b84a90f882fbf75536fd902e8a0a3f_dev]#

[wes hayutin (weshayutin)]

https://github.com/openstack/tripleo-ui/blob/master/docs/packaging.rst
https://github.com/rdo-packages/tripleo-ui-distgit/blob/rpm-master/openstack-tripleo-ui.spec

https://github.com/rdo-common/openstack-tripleo-ui-deps/blob/pike-rdo/openstack-tripleo-ui-deps.spec

[wes hayutin (weshayutin)]

This is failing in all our ci.centos master jobs, it does not fail in newton

https://ci.centos.org/view/rdo/view/tripleo-gate/job/tripleo-quickstart-extras-gate-master-tripleo-ci-delorean-full-minimal_pacemaker/

[Emilien Macchi (emilienm)]

I wonder if it's related to the stable releases, but I doubt it: https://review.openstack.org/#/c/526747/

I'll investigate over the weekend.

[wes hayutin (weshayutin)]

recreated the failure upstream

https://review.openstack.org/#/c/526876/

http://logs.openstack.org/76/526876/1/check/tripleo-ci-centos-7-undercloud-oooq/bded08e/job-output.txt.gz

[Alfredo Moralejo (amoralej)]

This may be related to a new version of openstack-tripleo-ui-deps bumped in https://review.rdoproject.org/r/#/c/10808/ . Last version of tripleo-ui built in trunk.rdoproject.org used openstack-tripleo-ui-deps-8-1, it looks suspicius. I'll engage someone from tripleo-ui team.

[yatin (yatinkarel)]

There may be issue with other dependencies as well, i tried locally a build with openstack-tripleo-ui-deps-7-6 but it still failed but at different point.
Generated logs from DLRN build(https://review.rdoproject.org/r/#/c/10937/):-
https://review.rdoproject.org/jenkins/job/DLRN-rpmbuild/20851/consoleText --> FAILED(From centos build)
https://review.rdoproject.org/jenkins/job/DLRN-rpmbuild-fedora/185/consoleText --> SUCCESS(From Fedora builds)

So we can find the cause from the difference above.

[yatin (yatinkarel)]

Yes, DLRN build is successful with openstack-tripleo-ui-deps == 8-1, Logs can be found in run of https://review.rdoproject.org/r/#/c/10937/2

[Ronelle Landy (rlandy)]

Checking with honza - still failing ci.centos check gates

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/528775

[Honza Pokorny (hpokorny)]

This might be unrelated, but for queens, the dep version should be 8 or more.

https://review.rdoproject.org/r/#/c/10982/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/528775
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart/commit/?id=fa91b3a03d509b24952501e3749d9b94b3c8af43
Submitter: Zuul
Branch: master

commit fa91b3a03d509b24952501e3749d9b94b3c8af43
Author: John Trowbridge <email address hidden>
Date: Mon Dec 18 12:48:32 2017 -0500

    Switch gate-check to THT patch

    Our gate-check jobs have been broken for a while due to a
    packaging issue with tripleo-ui. This switches to using a THT
    patch so that we can keep getting feedback that our gates work
    on a no-op change. We can switch back to the tripleo-ui patch
    once the related bug is fixed.

    Change-Id: I41add30cc8a71f86529b18e417a396992277fd9a
    Related-Bug: 1737335

[Alan Pevec (apevec)]

This should be resolved now, after hitting it as FTBFS in RDO Trunk master https://review.rdoproject.org/r/11169

Summary:
https://review.rdoproject.org/r/11202 ui-deps 8-3 rebuilt with NPM3
ui-deps 8-2 tarball was built on Fedora with NPM5 which is not compatible when building with NPM3
tripleo-ui will declare current restriction to nodejs6/npm3 in its bindep.txt and will push update to newer nodejs/npm later