Coverity issues in vrouter dp-core

[Andrei Bunghez]

Hi everybody,

Coverity reports the following issues inside vrouter dp-core (OpenContrail R3.2).

vr_qos.c:
In vr_fc_map_get, control may reach the generate_response label with an uninitialized resp variable. (59789)

vr_route.c:
In bridge_rtb_family_init, if algo_init fails, table is not freed. (59674)

vr_packet.h:
fmd_queue field is not initialized (it doesn't look like it's used anywhere either). (59782)

Best regards,
Andrei

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/38214
Submitter: Andrei Bunghez (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/38214
Committed: http://github.com/Juniper/contrail-vrouter/commit/4db98bc4a09da36a1165aaa9c1b3b988a24d73ca
Submitter: Zuul (<email address hidden>)
Branch: R3.2

commit 4db98bc4a09da36a1165aaa9c1b3b988a24d73ca
Author: Andrei Bunghez <email address hidden>
Date: Fri Dec 8 12:22:26 2017 +0200

Some dp-core fixes for coverity issues

vr_qos.c:
In vr_fc_map_get, control may reach the generate_response label with an uninitialized resp variable.
Initializing resp to NULL.

vr_route.c:
In bridge_rtb_family_init, if algo_init fails, table is not deallocated.
Freeing table on error case.

vr_packet.h:
fmd_queue field is not initialized (it doesnt't look used anywhere either).
Removing fmd_queue from forwarding metadata structure

Change-Id: Ife54d3ff95636535faa9f05ea03bb8eae7398231
Closes-Bug: #1737141

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/40388
Submitter: Andrei Bunghez (<email address hidden>)

[Hari Prasad Killi (haripk)]

please commit to master as well.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/40541
Submitter: Andrei Bunghez (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/40541
Committed: http://github.com/Juniper/contrail-vrouter/commit/d3e3f1e713f172e225c5eadc800df0e1a6f757ac
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit d3e3f1e713f172e225c5eadc800df0e1a6f757ac
Author: Andrei Bunghez <email address hidden>
Date: Fri Dec 8 12:22:26 2017 +0200

Some dp-core fixes for coverity issues

vr_qos.c:
In vr_fc_map_get, control may reach the generate_response label with an uninitialized resp variable.
Initializing resp to NULL.

vr_route.c:
In bridge_rtb_family_init, if algo_init fails, table is not deallocated.
Freeing table on error case.

vr_packet.h:
fmd_queue field is not initialized (it doesnt't look used anywhere either).
Removing fmd_queue from forwarding metadata structure

Change-Id: Ife54d3ff95636535faa9f05ea03bb8eae7398231
Closes-Bug: #1737141

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/40388
Committed: http://github.com/Juniper/contrail-vrouter/commit/8733582c24f9f7012450d48901cb135d6dedb06d
Submitter: Zuul (<email address hidden>)
Branch: R4.1

commit 8733582c24f9f7012450d48901cb135d6dedb06d
Author: Andrei Bunghez <email address hidden>
Date: Fri Dec 8 12:22:26 2017 +0200

Some dp-core fixes for coverity issues

vr_qos.c:
In vr_fc_map_get, control may reach the generate_response label with an uninitialized resp variable.
Initializing resp to NULL.

vr_route.c:
In bridge_rtb_family_init, if algo_init fails, table is not deallocated.
Freeing table on error case.

vr_packet.h:
fmd_queue field is not initialized (it doesnt't look used anywhere either).
Removing fmd_queue from forwarding metadata structure

Change-Id: Ife54d3ff95636535faa9f05ea03bb8eae7398231
Closes-Bug: #1737141