Watcher workload_stabilization strategy error

[Ivan Denezhkin]

There may be cases, when one of compute nodes
got into maintenance mode and don’t send any ceilometer metrics.
It may lead to returning of None in result of using statistic_aggregation method.
At least one strategy (workload_stabilization) set synthetic values[1] in this case.
Shouldn’t we exclude either host or instance if datasource can’t get actual metrics?

[1]: https://github.com/openstack/watcher/blob/1.5.0/watcher/decision_engine/strategy/strategies/workload_stabilization.py#L310

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/536786

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/536786
Committed: https://git.openstack.org/cgit/openstack/watcher/commit/?id=701b258dc76cd989e902efc2b507642359d1bfd7
Submitter: Zuul
Branch: master

commit 701b258dc76cd989e902efc2b507642359d1bfd7
Author: Alexander Chadin <email address hidden>
Date: Tue Jan 23 11:19:57 2018 +0300

    Fix workload_stabilization unavailable nodes and instances

    This patch set excludes nodes and instances from auditing
    if appropriate metrics aren't available.

    Change-Id: I87c6c249e3962f45d082f92d7e6e0be04e101799
    Closes-Bug: #1736982

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/537366

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/537366
Committed: https://git.openstack.org/cgit/openstack/watcher/commit/?id=8d61c1a2b4ab7158c00559ac0b5254cd2bbf5859
Submitter: Zuul
Branch: stable/pike

commit 8d61c1a2b4ab7158c00559ac0b5254cd2bbf5859
Author: Alexander Chadin <email address hidden>
Date: Tue Jan 23 11:19:57 2018 +0300

    Fix workload_stabilization unavailable nodes and instances

    This patch set excludes nodes and instances from auditing
    if appropriate metrics aren't available.

    Change-Id: I87c6c249e3962f45d082f92d7e6e0be04e101799
    Closes-Bug: #1736982
    (cherry picked from commit 701b258dc76cd989e902efc2b507642359d1bfd7)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/watcher 1.7.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/watcher 1.4.2 release.