Repeated import of cover art from files
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mixxx |
Triaged
|
Medium
|
Unassigned |
Bug Description
Cover art for the same track might be requested from UI components like widgets in the library, the cover art display on the deck and the spinnies almost concurrently. The cover art cache accepts multiple requests for the same track from different requestores if the cover is not cached already, although all requests reference the same file. Why? Because the requestId contains both the requestor and the cover hash.
As a consequence multiple subsequent read operations for the same cover art image are performed. For embedded cover art this becomes obvious from the logs, because a SoundSourceProxy is created and embedded cover art is parsed repeatedly from the audio file, e.g. when loading a track into a deck.
Pending requests for the same cover hash need to be combined instead of creating new requests.
summary: |
- Repeated reloading of cover art + Repeated import of cover art from files |
Changed in mixxx: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
Changed in mixxx: | |
milestone: | 2.2.0 → none |
Should IMHO be fixed before releasing 2.1.0.