Ocata to Pike upgrade: can't skip pre-upgrade validations on the non-controllers with upgrade-non-controller.sh

Bug #1735731 reported by Marios Andreou
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Marios Andreou

Bug Description

As first discussed in https://bugzilla.redhat.com/show_bug.cgi?id=1518662 the pre-upgrade service validations that are executed at step0 of the upgrade_tasks cannot be skipped for those nodes that are upgraded with the upgrade-non-controller.sh (default compute and swift. It is determined by the roles_data disable_upgrade_deployment flag). There is no way to pass the --skip-tags "validation" as we do for the controller upgrade with https://github.com/openstack/tripleo-heat-templates/blob/925d020d8f2988f7d180e756ec137fe6c8ccfb1f/puppet/upgrade_config.yaml#L37-L41

Revision history for this message
Carlos Camacho (ccamacho) wrote :

Haven't been included yet,

Fix available in: https://review.openstack.org/#/c/524183/

description: updated
Changed in tripleo:
milestone: queens-2 → queens-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/524183
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=1386a57989976f09dc9214e25cbdc8f306303bd9
Submitter: Zuul
Branch: master

commit 1386a57989976f09dc9214e25cbdc8f306303bd9
Author: marios <email address hidden>
Date: Thu Nov 30 15:49:58 2017 +0200

    Add --ansible-opts for upgrade-non-controller.sh O->P upgrade

    This allows the operator to pass extra options to the invocation
    of ansible-playbook. In particular this can be used to skip the
    validation tasks using the --skip-tags option, for example:
    --ansible-opts "--skip-tags validation -vvv" to skip validation
    and enable verbose logging

    Change-Id: If4690d86904554cece641ec8ba87880201e14679
    Closes-Bug: 1735731

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/526047

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/pike)

Reviewed: https://review.openstack.org/526047
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=40dd940f2a05807a300dc6bcddb04e7a408af897
Submitter: Zuul
Branch: stable/pike

commit 40dd940f2a05807a300dc6bcddb04e7a408af897
Author: marios <email address hidden>
Date: Thu Nov 30 15:49:58 2017 +0200

    Add --ansible-opts for upgrade-non-controller.sh O->P upgrade

    This allows the operator to pass extra options to the invocation
    of ansible-playbook. In particular this can be used to skip the
    validation tasks using the --skip-tags option, for example:
    --ansible-opts "--skip-tags validation -vvv" to skip validation
    and enable verbose logging

    Change-Id: If4690d86904554cece641ec8ba87880201e14679
    Closes-Bug: 1735731
    (cherry picked from commit 1386a57989976f09dc9214e25cbdc8f306303bd9)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 8.3.0

This issue was fixed in the openstack/tripleo-common 8.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 7.6.7

This issue was fixed in the openstack/tripleo-common 7.6.7 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.