widelands

Replay: Crash when buildings window get changed

Bug #1735294 reported by kaputtnik
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Critical
Unassigned
widelands build20-rc1

Bug Description

Start the reply of attached game and open the window for the outpost construction site at 19/60. As soon the outpost is build the replay crashes.

==22260==ERROR: AddressSanitizer: heap-use-after-free on address 0x6140002d2868 at pc 0x5614a9559159 bp 0x7ffe51c925a0 sp 0x7ffe51c92590

Maybe the same as https://bugs.launchpad.net/widelands/+bug/1735090

Tags: asan

Related branches

lp:~widelands-dev/widelands/keep_optr_in_ui
GunChleoc: Approve
kaputtnik (community): Approve (testing)
Diff: 835 lines (+180/-136)
17 files modified
src/logic/map_objects/tribes/building.cc (+0/-1)
src/logic/map_objects/tribes/building.h (+1/-1)
src/logic/map_objects/tribes/militarysite.cc (+0/-1)
src/wui/buildingwindow.cc (+70/-41)
src/wui/buildingwindow.h (+3/-6)
src/wui/constructionsitewindow.cc (+15/-8)
src/wui/constructionsitewindow.h (+1/-0)
src/wui/dismantlesitewindow.cc (+14/-7)
src/wui/dismantlesitewindow.h (+2/-2)
src/wui/militarysitewindow.cc (+4/-6)
src/wui/militarysitewindow.h (+4/-8)
src/wui/productionsitewindow.cc (+43/-24)
src/wui/productionsitewindow.h (+5/-6)
src/wui/trainingsitewindow.cc (+4/-6)
src/wui/trainingsitewindow.h (+4/-8)
src/wui/warehousewindow.cc (+7/-5)
src/wui/warehousewindow.h (+3/-6)
Revision history for this message
kaputtnik (franku) wrote :
summary: - Replay: Crash when buildings window is open and player dismantle it
+ Replay: Crash when buildings window get changed
Revision history for this message
kaputtnik (franku) wrote :

Same happens for all windows if they change her state.

This happens in current trunk r8511

GunChleoc (gunchleoc)
tags: added: asan
Revision history for this message
SirVer (sirver) wrote :

It is quite enjoyable to kink out all these accumulated bugs. thanks for reporting :)

Changed in widelands:
status: New → Confirmed
importance: Undecided → Critical
assignee: nobody → SirVer (sirver)
milestone: none → build20-rc1
SirVer (sirver)
Changed in widelands:
status: Confirmed → In Progress
Revision history for this message
SirVer (sirver) wrote :

With the attached branch, I can watch the replay until

Fatal Exception: [/Users/sirver/Desktop/Programming/cpp/widelands/bzr_repo/src/logic/replay_game_controller.cc:64] Trying to send a player command during replay

This is very likely bug 1735090.

Revision history for this message
GunChleoc (gunchleoc) wrote :

I got this with the barracks on the attached branch, I think while I was trying to close the window, but I'm not sure of the sequence.

Revision history for this message
GunChleoc (gunchleoc) wrote :

Last savegame for #5

Revision history for this message
GunChleoc (gunchleoc) wrote :

When I try to stop the barracks

Revision history for this message
SirVer (sirver) wrote :

I cannot repro the two crashes you posted, but your hint about start/stop indeed made me find a bug. It is fixed in the latest revision. Could you retest if that also fixes the crashs, Gun?

Revision history for this message
kaputtnik (franku) wrote :

Can't repro the crashe too. But GunChleoc has a better understanding of the code change and can surely better track possible bugs depending on it.

For me all is fine.

Revision history for this message
GunChleoc (gunchleoc) wrote :

Yes, that fixes it :)

GunChleoc (gunchleoc)
Changed in widelands:
status: In Progress → Fix Committed
assignee: SirVer (sirver) → nobody
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build20-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.