containerized ovs agent started in step4 instead of step5

[Alex Schultz]

Under baremetal, ovs agent is configured in step5 and expects neutron-server to be started first.
https://github.com/openstack/puppet-tripleo/blob/master/manifests/profile/base/neutron/ovs.pp#L37

In containerized world, it's being started in step4 with no requirement on neutron-server.
https://github.com/openstack/tripleo-heat-templates/blob/master/docker/services/neutron-ovs-agent.yaml#L123

[Alex Schultz (alex-schultz)]

We may be able to get away with it being started in step4 but we need to make sure that neutron-server is started first.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/523508

[Alex Schultz (alex-schultz)]

Actually it was moved to step5 on purpose due to Bug 1663273

[Brent Eagles (beagles)]

Moving to step five actually breaks the octavia deployment work that is in progress. While we are looking at converting to external deployment steps so it can be performed after step 5 so this would no be an issue but it's not clear why running the OVS agent at step 4 would break anything.

[Alex Schultz (alex-schultz)]

I think the issue was with multiple nodes, ovs starting before neutron server was ready on all the nodes. We can probably get away with just moving it later in step4 as it seems to be partially ok but we do need to make sure that neutron-server is started first.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/523508
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=c54c6222d8b517b8ee492caddaf47d2ef5780f31
Submitter: Zuul
Branch: master

commit c54c6222d8b517b8ee492caddaf47d2ef5780f31
Author: Alex Schultz <email address hidden>
Date: Tue Nov 28 12:15:14 2017 -0700

    Fix neutron agent start order

    In the baremetal deployment, we used to ensure that neutron-server was
    started prior to starting up the various agents. In the containerized
    deployment we need to ensure that we launch the agents after the server
    has been started. We can do this by configuring a start_order for each
    of the services.

    It should be noted that the ovs agent was actually configured to start
    in step5 on baremetal due to previous race conditions under HA
    deployments. This change leaves it in step4 but configures the
    start_order to be after the neutron-api service.

    Change-Id: I3794400ef5c8ae620961914831ff85e3438b0399
    Closes-Bug: #1734976
    Related-Bug: #1663273

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/524056

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/524056
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=6f250f2e05823d25db75287b921dc4f7a70ae542
Submitter: Zuul
Branch: stable/pike

commit 6f250f2e05823d25db75287b921dc4f7a70ae542
Author: Alex Schultz <email address hidden>
Date: Tue Nov 28 12:15:14 2017 -0700

    Fix neutron agent start order

    In the baremetal deployment, we used to ensure that neutron-server was
    started prior to starting up the various agents. In the containerized
    deployment we need to ensure that we launch the agents after the server
    has been started. We can do this by configuring a start_order for each
    of the services.

    It should be noted that the ovs agent was actually configured to start
    in step5 on baremetal due to previous race conditions under HA
    deployments. This change leaves it in step4 but configures the
    start_order to be after the neutron-api service.

    Change-Id: I3794400ef5c8ae620961914831ff85e3438b0399
    Closes-Bug: #1734976
    Related-Bug: #1663273
    (cherry picked from commit c54c6222d8b517b8ee492caddaf47d2ef5780f31)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.6 release.