placement: Request IDs are not passed to placement service

Bug #1734625 reported by Takashi Natsume
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Takashi Natsume
Queens
Fix Committed
Medium
Takashi Natsume

Bug Description

Placement service is called by other nova processes(nova-scheduler/nova-compute).
But their request IDs are not passed to placement service in the 'X-OpenStack-Request-ID' header of the request.
Therefore the caller's request IDs are not logged in the placement log.
It should be output for tracking.

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/525231

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/526263

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/526557

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/526823

Jay Pipes (jaypipes)
Changed in nova:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/525231
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c647865bf6d0c7048d5414564161f6303e7bc5ae
Submitter: Zuul
Branch: master

commit c647865bf6d0c7048d5414564161f6303e7bc5ae
Author: Takashi NATSUME <email address hidden>
Date: Mon Dec 4 21:57:23 2017 +0900

    [placement] Add sending global request ID in delete

    Add the 'X-Openstack-Request-Id' header
    in the request of DELETE.
    When deleteing a resource provider, the header is added.

    Subsequent patches will add the header in the other cases.

    Change-Id: Id78b849fe0f874d7a8e13c72f63b10724faf1aa7
    Partial-Bug: #1734625

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/531258

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/531266

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/531280

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/531299

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/526263
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0cbe9b23332155da7fab826077352b4adac483b6
Submitter: Zuul
Branch: master

commit 0cbe9b23332155da7fab826077352b4adac483b6
Author: Takashi NATSUME <email address hidden>
Date: Thu Dec 7 11:25:37 2017 +0900

    [placement] Add sending global request ID in delete (2)

    Add the 'X-Openstack-Request-Id' header in the request of DELETE.
    When deleting allocations for a server (instance),
    the header is added.

    Subsequent patches will add the header in the other cases.

    Change-Id: If38e4a6d49910f0aa5016e1bcb61aac2be416fa7
    Partial-Bug: #1734625

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/526557
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a326b03339123d79e71edfaca3215def3756b9ae
Submitter: Zuul
Branch: master

commit a326b03339123d79e71edfaca3215def3756b9ae
Author: Takashi NATSUME <email address hidden>
Date: Fri Dec 8 07:53:53 2017 +0900

    [placement] Add sending global request ID in delete (3)

    Add the 'X-Openstack-Request-Id' header in the request of DELETE.
    When deleteing resource provider inventories, the header is added.

    Subsequent patches will add the header in the other cases.

    Change-Id: I1dac3d340fe7077095d68f803cf5335ffd5b3364
    Partial-Bug: #1734625

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/526823
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=6079b722cbfc96dfab884a8350d8ade67e3fb840
Submitter: Zuul
Branch: master

commit 6079b722cbfc96dfab884a8350d8ade67e3fb840
Author: Takashi NATSUME <email address hidden>
Date: Sat Dec 9 14:04:34 2017 +0900

    [placement] Add sending global request ID in post

    Add the 'X-Openstack-Request-Id' header
    in the request of POST in SchedulerReportClient.
    When creating a resource provider and creating a resource class,
    the header is added.

    Subsequent patches will add the header in the other cases.

    Change-Id: I39d8c71432b3adf7e5bdde1c6cb6f089a9c79614
    Partial-Bug: #1734625

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/531258
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5d928ae2e00ac55582210a8df5afe6e3f45ff2bb
Submitter: Zuul
Branch: master

commit 5d928ae2e00ac55582210a8df5afe6e3f45ff2bb
Author: Takashi NATSUME <email address hidden>
Date: Fri Jan 5 07:08:53 2018 +0900

    [placement] Add sending global request ID in put (1)

    Add the 'X-Openstack-Request-Id' header
    in the request of PUT in SchedulerReportClient.
    When updating inventories, deleting inventories
    (microversion 1.5 not available) and ensuring
    a resource class, the header is added.

    Subsequent patches will add the header in the other cases.

    Change-Id: I02b9f2ef1cbd16d5bf9c4084bc652e94875a6c2a
    Partial-Bug: #1734625

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/531266
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=cf375d2ef3fe1d98369714413f3fff692a6f7201
Submitter: Zuul
Branch: master

commit cf375d2ef3fe1d98369714413f3fff692a6f7201
Author: Takashi NATSUME <email address hidden>
Date: Fri Jan 5 08:05:15 2018 +0900

    [placement] Add sending global request ID in put (2)

    Add the 'X-Openstack-Request-Id' header
    in the request of PUT in SchedulerReportClient.
    When claiming resources, the header is added.

    Subsequent patches will add the header in the other cases.

    Change-Id: I73d5aceed399ae906ee577e91c80551284faf21e
    Partial-Bug: #1734625

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/531280
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f66bd7369a86b1833cd146de67c4337ea150f087
Submitter: Zuul
Branch: master

commit f66bd7369a86b1833cd146de67c4337ea150f087
Author: Takashi NATSUME <email address hidden>
Date: Fri Jan 5 10:18:47 2018 +0900

    [placement] Add sending global request ID in put (3)

    Add the 'X-Openstack-Request-Id' header
    in the request of PUT in SchedulerReportClient.
    When removing a resource provider from an instance allocation
    and putting allocations to a resource provider,
    the header is added.

    Subsequent patches will add the header in the other cases.

    Change-Id: I7891b98f225f97ad47f189afb9110ef31c810717
    Partial-Bug: #1734625

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/531299
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ab4efbba61fb0dd0266e42e48555f80ddde72efd
Submitter: Zuul
Branch: master

commit ab4efbba61fb0dd0266e42e48555f80ddde72efd
Author: Takashi NATSUME <email address hidden>
Date: Fri Jan 5 11:42:17 2018 +0900

    [placement] Add sending global request ID in get

    Add the 'X-Openstack-Request-Id' header
    in the request of GET in SchedulerReportClient.

    Change-Id: I306ac6f5c6b67d77d91a7ba24d4d863ab3e1bf5c
    Closes-Bug: #1734625

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/543113

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/543116

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/queens)

Reviewed: https://review.openstack.org/543113
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=852de1ee7302bbc818a01510d72b6bafddea4cbe
Submitter: Zuul
Branch: stable/queens

commit 852de1ee7302bbc818a01510d72b6bafddea4cbe
Author: Takashi NATSUME <email address hidden>
Date: Fri Jan 5 10:18:47 2018 +0900

    [placement] Add sending global request ID in put (3)

    Add the 'X-Openstack-Request-Id' header
    in the request of PUT in SchedulerReportClient.
    When removing a resource provider from an instance allocation
    and putting allocations to a resource provider,
    the header is added.

    Subsequent patches will add the header in the other cases.

    Conflicts:
        nova/scheduler/client/report.py

    NOTE(takashin): The conflict is due to
    I2563213dc3b184049af336f0807c4cb4690a9f9a is not backported.

    Change-Id: I7891b98f225f97ad47f189afb9110ef31c810717
    Partial-Bug: #1734625
    (cherry picked from commit f66bd7369a86b1833cd146de67c4337ea150f087)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/543116
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d49a6b8999c4b4986ea0ac0ce9f1dca2c076ee17
Submitter: Zuul
Branch: stable/queens

commit d49a6b8999c4b4986ea0ac0ce9f1dca2c076ee17
Author: Takashi NATSUME <email address hidden>
Date: Fri Jan 5 11:42:17 2018 +0900

    [placement] Add sending global request ID in get

    Add the 'X-Openstack-Request-Id' header
    in the request of GET in SchedulerReportClient.

    Conflicts:
      nova/scheduler/client/report.py
      nova/tests/functional/api/openstack/placement/test_report_client.py
      nova/tests/unit/scheduler/client/test_report.py

    NOTE(takashin):
      The conflicts are due to Iab366da7623e5e31b8416e89fee7d418f7bf9b30.
      This patch should have been merged to stable/queens before
      Iab366da7623e5e31b8416e89fee7d418f7bf9b30!

    Change-Id: I306ac6f5c6b67d77d91a7ba24d4d863ab3e1bf5c
    Closes-Bug: #1734625
    (cherry picked from commit ab4efbba61fb0dd0266e42e48555f80ddde72efd)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 17.0.2

This issue was fixed in the openstack/nova 17.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 18.0.0.0b1

This issue was fixed in the openstack/nova 18.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.