Property LibvirtTLSPassword not assigned

[Lee Yarwood]

Description
===========
Getting the following error during a stack update for FFU:

~~~
$ openstack overcloud deploy --templates /home/stack/tripleo-heat-templates \
[..]
  -e /home/stack/docker_registry.yaml \
  -e /home/stack/tripleo-heat-templates/environments/docker.yaml \
  -e /home/stack/tripleo-heat-templates/environments/fast-forward-upgrade.yaml \
  -e /home/stack/tripleo-heat-templates/environments/noop-deploy-steps.yaml
[..]
2017-11-23 22:18:25Z [overcloud-CephStorageServiceChain-e4yzrgx4jnsr.ServiceChain.9]: CREATE_IN_PROGRESS state changed

 Stack overcloud UPDATE_FAILED
[..]
overcloud.ComputeServiceChain.ServiceChain:
  resource_type: OS::Heat::ResourceChain
  physical_resource_id:
  status: CREATE_FAILED
  status_reason: |
    resources.ServiceChain: Property error: resources[20].properties: Property LibvirtTLSPassword not assigned
~~~

Steps to reproduce
==================
Any stack update appears to reproduce this issue.

Expected result
===============
Stack update completes.

Actual result
=============
Stack update fails due to a missing property.

Environment
===========
1. Exact version of OpenStack you are running. See the following
  list for all releases: http://docs.openstack.org/releases/

   https://review.openstack.org/#/q/topic:bp/fast-forward-upgrades

2. Which storage type did you use?
   (For example: Ceph, LVM, ...)
   What's the version of that?

   N/A

3. Which networking type did you use?
   (For example: Neutron with OpenVSwitch, ...)

   N/A

Logs & Configs
==============
See above.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/522676

[Oliver Walsh (owalsh)]

Once we have master promotion I think this should be resolved. It should only be an issue when running off t-h-t master.

https://review.openstack.org/520254 has merged to t-h-t master but the tripleo-common change it depends on (https://review.openstack.org/520135) hasn't been promoted yet so the package on the undercloud is out of sync.

[Oliver Walsh (owalsh)]

In the meantime, easiest workaround would be to set this in parameter_defaults to anything e.g
foo.yaml:
parameter_defaults:
  LibvirtTLSPassword: foobar

then overcloud deploy --templates my-checked-out-t-h-t .... -e foo.yaml

[OpenStack Infra (hudson-openstack)]

Change abandoned by Lee Yarwood (<email address hidden>) on branch: master
Review: https://review.openstack.org/522676