notification_format in nova.conf should be "unversioned"

[Sven Anderson]

Description of problem:

The default for notification_format in nova.conf is "both"

As a result messages get sent to both unversioned and versioned queues, but there is no consumer for the versioned_notifications queues. As a result they grow up slowly:

# rabbitmqctl list_queues name consumers messages| grep notifications
notifications.error 3 0
notifications.warn 3 0
notifications.debug 3 0
notifications.critical 3 0
notifications.sample 3 0
notifications.audit 3 0
versioned_notifications.info 0 26
notifications.info 3 0

For now notification_format should be set to unversioned as default on controllers and computes.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/522644

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/522645

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/522645
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=6d0fc77f43e7789f6eed5050a7f93533c28e9e2c
Submitter: Zuul
Branch: stable/ocata

commit 6d0fc77f43e7789f6eed5050a7f93533c28e9e2c
Author: Sven Anderson <email address hidden>
Date: Thu Aug 17 18:10:13 2017 +0200

    Set notification_format to 'unversioned'

    Currently there is no consumer for the versioned notification format,
    which results in messages queueing up for infinite time. Until we
    have a consumer for the 'versioned' format, we set it to
    'unversioned'.

    Closes-Bug: #1734185
    Depends-On: Id08b2d5a1e87825b182e767bffc4c15e5ce9968f
    Change-Id: I5be547acbd1245de42572941d2185863697f89bd
    (cherry picked from commit 1624e1cf19b19b4342fe143753df1fa030593294)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/522644
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=3917a18df93146772a9e89d8b8958eb6b80bdfe7
Submitter: Zuul
Branch: stable/pike

commit 3917a18df93146772a9e89d8b8958eb6b80bdfe7
Author: Sven Anderson <email address hidden>
Date: Thu Aug 17 18:10:13 2017 +0200

    Set notification_format to 'unversioned'

    Currently there is no consumer for the versioned notification format,
    which results in messages queueing up for infinite time. Until we
    have a consumer for the 'versioned' format, we set it to
    'unversioned'.

    Closes-Bug: #1734185
    Depends-On: Id08b2d5a1e87825b182e767bffc4c15e5ce9968f
    Change-Id: I5be547acbd1245de42572941d2185863697f89bd
    (cherry picked from commit 1624e1cf19b19b4342fe143753df1fa030593294)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.2.7 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.6 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/554847

[Sven Anderson (ansiwen)]

For completeness the related change (overcloud) on master:
https://review.openstack.org/#/c/494628

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/554847
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=122807b013eede7988fabab9cfd789117cb729d8
Submitter: Zuul
Branch: master

commit 122807b013eede7988fabab9cfd789117cb729d8
Author: Oliver Walsh <email address hidden>
Date: Wed Mar 21 09:40:48 2018 +0000

    Set undercloud nova notification_format to 'unversioned'

    Currently there is no consumer for the versioned notification queue, which
    results in the queue growing infinitely large. Until we have a consumer set
    the notification format to 'unversioned' only.

    Change-Id: I972dd8513c6706d03c328c961bd77eea2672bba2
    Resolves-Bug: #1734185

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/577790

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/577792

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/577790
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=0449f733771d43ffe66f82b5c6739590a698f615
Submitter: Zuul
Branch: stable/queens

commit 0449f733771d43ffe66f82b5c6739590a698f615
Author: Oliver Walsh <email address hidden>
Date: Wed Mar 21 09:40:48 2018 +0000

    Set undercloud nova notification_format to 'unversioned'

    Currently there is no consumer for the versioned notification queue, which
    results in the queue growing infinitely large. Until we have a consumer set
    the notification format to 'unversioned' only.

    Change-Id: I972dd8513c6706d03c328c961bd77eea2672bba2
    Resolves-Bug: #1734185

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/577792
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=fb7c1a9c81a633ad3662f29c3c1dc7789f2ffa81
Submitter: Zuul
Branch: stable/pike

commit fb7c1a9c81a633ad3662f29c3c1dc7789f2ffa81
Author: Oliver Walsh <email address hidden>
Date: Wed Mar 21 09:40:48 2018 +0000

    Set undercloud nova notification_format to 'unversioned'

    Currently there is no consumer for the versioned notification queue, which
    results in the queue growing infinitely large. Until we have a consumer set
    the notification format to 'unversioned' only.

    Change-Id: I972dd8513c6706d03c328c961bd77eea2672bba2
    Resolves-Bug: #1734185