Ocata to Pike upgrade for non controllers error for UpgradeRemoveUnusedPackages

[Marios Andreou]

As discussed in https://bugzilla.redhat.com/show_bug.cgi?id=1516210 when you set the UpgradeRemoveUnusedPackages parameter, during the non controllers upgrade you see the error "expected string or buffer". Alternatively and as discussed in https://bugzilla.redhat.com/show_bug.cgi?id=1516308 if you don't set this parameter packages are still removed from the non controller nodes.

There is a bug in the way we handle these upgrade_tasks (an example of such a task is [0]) in the tripleo_common/utils/config.py when translating the "step: x" to "when: step"

Will post a fix momentarily.

[0] https://github.com/openstack/tripleo-heat-templates/blob/7984be92db977aeb85f5c589191562156fb35e56/docker/services/ceilometer-agent-compute.yaml#L139-L143

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/522539

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/522540

[OpenStack Infra (hudson-openstack)]

Change abandoned by Paul Belanger (<email address hidden>) on branch: master
Review: https://review.openstack.org/522539
Reason: We are dealing with an issue in zuulv3 today, as such we need to abandon / restore this patch to correct the issue. Apologies for the inconvenience.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/522539
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=2a9012a3f0ffcac7d946581b68f14daf118939c3
Submitter: Zuul
Branch: master

commit 2a9012a3f0ffcac7d946581b68f14daf118939c3
Author: marios <email address hidden>
Date: Thu Nov 23 14:23:34 2017 +0200

    Handle 'false' in when statements for ansible upgrade_tasks

    The upgrade_task that remove packages have a when clause that is
    set from the UpgradeRemoveUnusedPackages parameter. When we write
    the overcloud config and translate "tags: step" to "when: step"
    we must be careful to handle these tasks otherwise we get errors.
    See the bug for more info.

    Change-Id: Ic10ae0f3262a93ceec6ba8d938f36c937f3b594c
    Closes-Bug: 1734118

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/522540
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=ce24645d6efb7b9d9c97648fdb778c7344a5e88a
Submitter: Zuul
Branch: stable/pike

commit ce24645d6efb7b9d9c97648fdb778c7344a5e88a
Author: marios <email address hidden>
Date: Thu Nov 23 14:23:34 2017 +0200

    Handle 'false' in when statements for ansible upgrade_tasks

    The upgrade_task that remove packages have a when clause that is
    set from the UpgradeRemoveUnusedPackages parameter. When we write
    the overcloud config and translate "tags: step" to "when: step"
    we must be careful to handle these tasks otherwise we get errors.
    See the bug for more info.

    Change-Id: Ic10ae0f3262a93ceec6ba8d938f36c937f3b594c
    Closes-Bug: 1734118
    (cherry picked from commit 2a9012a3f0ffcac7d946581b68f14daf118939c3)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 8.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 7.6.6 release.