lack of model context in cleanup errors makes diagnosis difficult

[Andrew Wilkins]

Example cleanup error:
    2017-11-22 07:29:08 ERROR juju.state cleanup.go:126 cleanup failed for machine("0"): machine 0 has attachments [volume-0]

It's impossible to tell from this which model is affected.

[John A Meinel (jameinel)]

fwiw, both PingBatcher and at least one other place in the code has started
including I think 6 hex digits of the model-uuid to give context.
uuids.Add(docId[:6])

That often is enough to guarantee uniqueness, and not so much as to
completely destroy the log line.

On Wed, Nov 22, 2017 at 11:33 AM, Andrew Wilkins <
<email address hidden>> wrote:

> Public bug reported:
>
> Example cleanup error:
> 2017-11-22 07:29:08 ERROR juju.state cleanup.go:126 cleanup failed for
> machine("0"): machine 0 has attachments [volume-0]
>
> It's impossible to tell from this which model is affected.
>
> ** Affects: juju
> Importance: High
> Status: Triaged
>
> --
> You received this bug notification because you are subscribed to juju.
> Matching subscriptions: juju bugs
> https://bugs.launchpad.net/bugs/1733791
>
> Title:
> lack of model context in cleanup errors makes diagnosis difficult
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/juju/+bug/1733791/+subscriptions
>

[Joseph Phillips (manadart)]

Debug logging during cleanup now includes the first 6 digits of the model UUID.
Errors include the full model UUID.