cmd/jujud/agent: restore-status watching code is untested

Bug #1733552 reported by Andrew Wilkins
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Juju
Triaged
Low
Unassigned

Bug Description

The machine agent has code to watch the restore status in state, so it can block clients during restore. This code is not properly tested. The only tests we had as at 2.1-rc1 were setting the status through an internal method rather than through state, so we were effectively testing:

   a = b
   assert(a == b)

(and also checking some errors that are ignored in the production code, probably because the errors returned weren't valid)

Andrew Wilkins (axwalk)
Changed in juju:
importance: Critical → High
Changed in juju:
milestone: 2.4-beta1 → none
tags: added: restore-backup
Ian Booth (wallyworld)
tags: added: backup-restore
removed: restore-backup
Revision history for this message
Canonical Juju QA Bot (juju-qa-bot) wrote :

This bug has not been updated in 2 years, so we're marking it Low importance. If you believe this is incorrect, please update the importance.

Changed in juju:
importance: High → Low
tags: added: expirebugs-bot
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.