Game information update fails with multiple items

[Jukka Pakarinen]

When first three items are selected from the list of replay view by pressing ctrl+cliks and then unselected two last ones, game information view doesn't show what it should. There is some other clinking combinations when this oddness turning up.

The delete buttons seems to delete the items selected from the list even when game information shows something else.

[Jukka Pakarinen (flegu)]

The problem is found from trunk (revno 8486) on Debian 9.1.

[GunChleoc (gunchleoc)]

We are missing an update of GameData somewhere. That's either a bug in the loading screen, or the Table object isn't sending a selected signal.

[Jukka Pakarinen (flegu)]

I think the following change fixes the bug but I'm not sure is this the right way to fix it.

=== modified file 'src/ui_basic/table.cc'
--- src/ui_basic/table.cc 2017-11-06 20:19:56 +0000
+++ src/ui_basic/table.cc 2017-12-13 18:22:48 +0000
@@ -426,7 +426,7 @@
  * Args: i the entry to select
  */
 void Table<void*>::select(const uint32_t i) {
- if (empty() || selection_ == i || i == no_selection_index())
+ if (empty() || i == no_selection_index())
                return;

        selection_ = i;

So, what happens if at least 3 items are selected (e.g index values 2 3 4 5) and two of them are unselected, but not the first one (2).

Unselect index 5: input value of i=2 is set to selection_ and selected(selection_) is called.
Unselect index 4: input value of i=2 is not set to selection_ and selected(selection_) is not called because selection_ == i.

[GunChleoc (gunchleoc)]

I can't review this without having a branch, the code is too complex for that.

[Jukka Pakarinen (flegu)]

I tried to link the branch to this bug yesterday and also few moments ago but the interface said "Timeout error, please try again in a few minutes".

So this is the branch
https://code.launchpad.net/~widelands-dev/widelands/bug-1733212-game-information-update-fails

[GunChleoc (gunchleoc)]

Yes, Launchpad sometimes does that. Thanks for the branch :)

[GunChleoc (gunchleoc)]

Reviewed now and merged.

BTW you can open up merge requests any time, even if you're unsure if the code is correct - it's an easy way to discuss the code. And you've been providing good code anyway :)

[GunChleoc (gunchleoc)]

Fixed in build20-rc1