Validation of non-permuted repeat function fails with mixed data sources

[Zane Bitter]

To fix bug 1629899, we substitute an empty list for any None values in the for_each section of the repeat function. This allows us to use the function during property validation.

However, when the function is used with the permutations: false argument, we also check that the lengths of all the arguments match. The result is that if arguments come from different sources - e.g. one from get_attr and others from e.g. get_param - the lengths may not match and validation will fail.

A workaround is to create OS::Heat::Value resources for each of the for_each lists, so that all of the values can be obtained using get_attr.

We should probably bypass the length check if any of the for_each lists are None.

[Rabi Mishra (rabi)]

It seems that length check was added latter in https://review.openstack.org/#/c/473360/heat/engine/hot/functions.py

[Zane Bitter (zaneb)]

Yes, the permutations: false argument didn't exist at the time bug 1629899 was fixed. So not your fault ;)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/527001

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/527001
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=89643db0056c4b77e6ab67f6cc1b3435ee2b1435
Submitter: Zuul
Branch: master

commit 89643db0056c4b77e6ab67f6cc1b3435ee2b1435
Author: Khaled Qarout <email address hidden>
Date: Tue Dec 12 01:37:33 2017 -0500

    Bypass list length check for None values in repeat function

    Attributes may return "None" before the resource is created,
    so the length check for for_each lists in repeat function will fail.
    Bybass the length check for the None list

    Change-Id: Ida81060e62340b3ea37ba0fdd7443dc88ba6c5aa
    Closes-bug: #1732934

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/530942

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/530942
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=bd8df9a8b9fb379709e00bb01bb36bf58a23581a
Submitter: Zuul
Branch: master

commit bd8df9a8b9fb379709e00bb01bb36bf58a23581a
Author: Luis Tomas Bolivar <email address hidden>
Date: Wed Jan 3 16:08:46 2018 +0100

    Fix bypass list length check when all values are None

    The patch https://review.openstack.org/#/c/527001/ bypassed the None
    list but did not consider the case where all the for_each lists are
    getting their values from attributes and therefore are None.

    This patch set fix it by also skipping the check if all the values
    are None -- as len(value_lens) would be 0 in that case.

    Closes-bug: #1732934
    Change-Id: Iba574bbd3877f9ca1ca755c384b3ddb47aec711c

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat 10.0.0.0b3 development milestone.