Stage call fails with TypeError

Bug #1732835 reported by Abhishek Kekane
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
High
Abhishek Kekane

Bug Description

If store_backend denies writing to store then glance_store will raise 'StorageWriteDenied' error.
After catching this exception at glance side, unstage call [1] will fail with TypeError as it requires 3 arguments and only two were provided.

Actual call:
self._unstage(image_repo, image)

Expected call:
self._unstage(image_repo, image, staging_store)

[1] https://github.com/openstack/glance/blob/master/glance/api/v2/image_data.py#L335

Changed in glance:
assignee: nobody → Abhishek Kekane (abhishek-kekane)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/520945

Changed in glance:
status: New → In Progress
Changed in glance:
importance: Undecided → High
milestone: none → queens-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/520945
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=ef5742cabb0652be513058939398208737a877cf
Submitter: Zuul
Branch: master

commit ef5742cabb0652be513058939398208737a877cf
Author: Abhishek Kekane <email address hidden>
Date: Fri Nov 17 06:28:19 2017 +0000

    Fix unstage after staging store denies write

    If store_backend denies writing to store then glance_store will raise
    'StorageWriteDenied' error. After catching this exception at glance
    side, unstage call fails with TypeError as it requires 3 arguments
    and only two were provided.

    Passed 'staging_store' argument to _unstage call for correcting the
    same.

    Change-Id: I6d3d1b304e84fbfc1d653b3640ed92082f5b11cd
    Closes-Bug: #1732835

Changed in glance:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/glance 16.0.0.0b2

This issue was fixed in the openstack/glance 16.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.