Unreachable 'ImageSizeLimitExceeded' exception block in stage call
Bug #1732830 reported by
Abhishek Kekane
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Glance |
Fix Released
|
Low
|
Abhishek Kekane |
Bug Description
ImageSizeLimitE
we are using sotre_backend.add (filesystem.add in this case) and it will
raise 'exceptions.
[1] https:/
[2] https:/
Changed in glance: | |
assignee: | nobody → Abhishek Kekane (abhishek-kekane) |
Changed in glance: | |
milestone: | none → queens-2 |
To post a comment you must log in.
I think Abhishek's analysis is correct. The upload() function, which also catches this exception, eventually uses some kind of limiting reader to store the image data, which is why it needs to catch ImageSizeLimitE xceeded. But stage() is using store.add() directly, so it won't see that.
As a side point, the current import workflow will allow an end user to stage something super enormous; the size limit isn't checked until the import call happens. Just wanted to mention that.