DM: Physical Device Model is case sensitive

Bug #1732775 reported by chhandak
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R4.1
Fix Committed
High
Suresh Balineni
Trunk
Fix Committed
High
Suresh Balineni

Bug Description

WHiloe creating Physcial Device, model is case sensitive. Model always has to be enteretd as juniper. When we specify in any other format, DM silently fail to push any config. User only can get some information from contrail-device-manager.log. Because UI has no such validation. DM should accept the input case insensitive

chhandak (chhandak)
Changed in juniperopenstack:
importance: Undecided → High
assignee: nobody → Suresh Balineni (sbalineni)
milestone: none → r4.1.0.0-fcs
information type: Proprietary → Public
summary: - DM: Model is case sensitive
+ DM: Physcial Device Model is case sensitive
summary: - DM: Physcial Device Model is case sensitive
+ DM: Physical Device Model is case sensitive
Vinod Nair (vinodnair)
Changed in juniperopenstack:
milestone: r4.1.0.0-fcs → r5.0.0
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.1

Review in progress for https://review.opencontrail.org/37688
Submitter: Suresh Balineni (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/37688
Committed: http://github.com/Juniper/contrail-controller/commit/4e5581f97ea2cbe132bb6e6f1abfba3f8a80b621
Submitter: Zuul (<email address hidden>)
Branch: R4.1

commit 4e5581f97ea2cbe132bb6e6f1abfba3f8a80b621
Author: sbalineni <email address hidden>
Date: Mon Nov 20 11:05:18 2017 -0800

[DM]: PR product/vendor names should be case insensitive

- Plugin names should be case-insensitive
- User input PR product/vendor names should be case-insensitive
- Added following checks:
- PR may have vendor or product values Nulls - handle gracefully
- PR may have product name empty string, do not map to plugin (prefix check will not help)

In either case, plugin infra should handle/pick right plugin.
UT will be added to mainline commit. Verified cases on system setup environment.

Change-Id: I07001a0a0f7749e52ddd50d9f2ab5301b0ad9919
Closes-Bug: #1732775

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/38364
Submitter: Suresh Balineni (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/38364
Committed: http://github.com/Juniper/contrail-controller/commit/b5dbc83b2b0cea78fb96918eb9f955b25bd207dd
Submitter: Zuul (<email address hidden>)
Branch: master

commit b5dbc83b2b0cea78fb96918eb9f955b25bd207dd
Author: sbalineni <email address hidden>
Date: Mon Nov 20 11:05:18 2017 -0800

[DM]: PR product/vendor names should be case insensitive

- Plugin names should be case-insensitive
- User input PR product/vendor names should be case-insensitive
- Added following checks:
- PR may have vendor or product values Nulls - handle gracefully
- PR may have product name empty string, do not map to plugin (prefix check will not help)

In either case, plugin infra should handle/pick right plugin.

- UT added

Change-Id: I07001a0a0f7749e52ddd50d9f2ab5301b0ad9919
Closes-Bug: #1732775

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.