controller mappings with identical names in combobox

Bug #1732712 reported by Foss-4
18
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
Be

Bug Description

otherwise it's not possible for users to differentiate between local preset and actual preset.

Revision history for this message
Foss-4 (foss-4) wrote :
Be (be.ing)
Changed in mixxx:
status: New → Confirmed
importance: Undecided → Low
tags: added: controllers usability
Be (be.ing)
Changed in mixxx:
assignee: nobody → Be (be.ing)
milestone: none → 2.1.0
Revision history for this message
ronso0 (ronso0) wrote :

Maybe we can append (user) so the distinction is
(user) vs. (official)
While (official) is displayed only if a modified version exists

Revision history for this message
Sean M. Pappalardo (pegasus-renegadetech) wrote :

Or take up as little space as possible (and reduce the number of strings to translate) by just marking user/local presets with a leading asterisk (*) and place text under the drop-down to the effect of "* user-modified version"

Revision history for this message
Daniel Schürmann (daschuer) wrote :

This is a interface related bug. Fix or move?

Revision history for this message
Be (be.ing) wrote :

I am not clear what you are asking. We should fix this for 2.1. I don't think it's feasible to come up with a solid solution in the next 2 days for the initial beta release, but it should be fixed for the final release.

Revision history for this message
Daniel Schürmann (daschuer) wrote :

OK

Revision history for this message
Sébastien BLAISOT (sblaisot) wrote :

My heart say "fix it". Then I remember we should be in ui and string freeze.

So I'm in the middle.

Revision history for this message
Dale (dj-kaza) wrote :

Be pointed me here due to a related but (I feel) different issue. I am creating a mapping from scratch so only have xml and js files in the user directory with the name/description etc. If I edit the Action within Mixxx instead of saving over the old file it is creating a new file and then both are showing up under the original name in the list.

Personally I feel this should be writing over the original file.

As to how to distinguish between default and user installed: I would say appending (user) to the user installed/edited ones and leaving the system ones as they are would work.

And if new files continue to be created upon editing within Mixxx then maybe make it (user:filename) for those with more than a single entry. But I really can't understand why you are doing this in the first place.

Revision history for this message
Be (be.ing) wrote :

I think there are two changes needed for a good solution to this issue:
1. Distinguish local from system mappings in the mapping selection combobox.
2. Only save a mapping to the user folder if it has been modified by the user.

Changed in mixxx:
status: Confirmed → In Progress
summary: - append "(local)" to controller preset name
+ controller mappings with identical names in combobox
Revision history for this message
Be (be.ing) wrote :
Be (be.ing)
Changed in mixxx:
status: In Progress → Won't Fix
status: Won't Fix → Fix Committed
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8974

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.