quickstart on libvirt fails on malformed conditional

[Jiří Stránský]

The error is:

TASK [undercloud-deploy : set vbmc address if there is a (nat) network defined with an address] ***
fatal: [undercloud]: FAILED! => {"failed": true, "msg": "The conditional check '{{ networks|selectattr('address', 'defined')|map(attribute='name')|list|length is greaterthan 0}}' failed. The error was: template error while templating string: no test named 'greaterthan'. String: {{ networks|selectattr('address', 'defined')|map(attribute='name')|list|length is greaterthan 0}}\n\nThe error appears to have been in '/root/.quickstart/usr/local/share/ansible/roles/undercloud-deploy/tasks/configure-vbmc.yml': line 51, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n# The first network defined with an address will be used for vbmc access.\n- name: set vbmc address if there is a (nat) network defined with an address\n ^ here\n"}
        to retry, use: --limit @/root/.quickstart/playbooks/new-upto-overcloud-prep.retry

It appears that

when: "{{ networks|selectattr('address', 'defined')|map(attribute='name')|list|length is greaterthan 0}}"

might have worked on earlier Ansible version, but it doesn't work anymore.

CI doesn't look affected, likely the OS infra and OVB deploy paths don't exercise this conditional.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/520057

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/520057
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=af0eec6bd5b76941614fb3521f7c20e7da37fe92
Submitter: Zuul
Branch: master

commit af0eec6bd5b76941614fb3521f7c20e7da37fe92
Author: Jiri Stransky <email address hidden>
Date: Wed Nov 15 13:17:54 2017 +0100

    Fix conditional to be compatible with new Ansible

    The old conditional caused an error when used with new Ansible, "no
    test named 'greaterthan'".

    Change-Id: I5c61da71794bba0b24f5aa69cdd38cfbcab0ef4d
    Closes-Bug: #1732423

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-quickstart-extras 2.1.1 release.