_parse_block_device returns inconsistent types

Bug #1732413 reported by Liam Young
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Cinder Charm
Fix Released
Medium
Liam Young

Bug Description

_parse_block_device returns a tuple. Depending on the code path sometimes it returns (str, int) and sometimes it returns (str, str)

Liam Young (gnuoy)
Changed in charm-cinder:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Liam Young (gnuoy)
milestone: none → 17.11
Changed in charm-cinder:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-cinder (master)

Reviewed: https://review.openstack.org/520053
Committed: https://git.openstack.org/cgit/openstack/charm-cinder/commit/?id=d8d180aaaf22fcf355aa6fa62d5fb65de77255ae
Submitter: Zuul
Branch: master

commit d8d180aaaf22fcf355aa6fa62d5fb65de77255ae
Author: Liam Young <email address hidden>
Date: Wed Nov 15 11:39:07 2017 +0000

    Fix _parse_block_device to return (str, int)

    _parse_block_device was returning inconsistent types. This seems
    to have been working by accident under py2 but fails for py3.

    This change fixes _parse_block_device to always returns (str, int)

    Closes-Bug: #1732413
    Change-Id: If0bfb4030ab9acfdf599ef8e70fed14816df3e26

Changed in charm-cinder:
status: In Progress → Fix Committed
James Page (james-page)
Changed in charm-cinder:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.