[RFE] Configuration option for a default resource class

Bug #1732190 reported by Dmitry Tantsur
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Wishlist
Dmitry Tantsur
puppet-ironic
Fix Released
Undecided
Dmitry Tantsur
tripleo
Fix Released
Wishlist
Dmitry Tantsur

Bug Description

Some operators indicated at the Forum that they want to use only one resource class. We can introduce a new option default_resource_class (None by default) that will specify the resource class to use for new nodes, when no resource class is provided.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/522873

Changed in ironic:
assignee: nobody → Dmitry Tantsur (divius)
status: Confirmed → In Progress
Dmitry Tantsur (divius)
Changed in puppet-ironic:
assignee: nobody → Dmitry Tantsur (divius)
Dmitry Tantsur (divius)
Changed in tripleo:
status: New → Triaged
assignee: nobody → Dmitry Tantsur (divius)
importance: Undecided → Low
importance: Low → Wishlist
milestone: none → queens-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/523089

Changed in puppet-ironic:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/522873
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=265993316b53abac234600b4b516965b82270e16
Submitter: Zuul
Branch: master

commit 265993316b53abac234600b4b516965b82270e16
Author: Dmitry Tantsur <email address hidden>
Date: Fri Nov 24 17:54:22 2017 +0100

    Add a configuration option for the default resource class

    If no resource class is provided in a creation request, the value of
    the new ``default_resource_class`` configuration option is used.

    While this feature is implemented on the API level, it's not a part of
    the API contract, so it's not covered by a microversion. It's particularly
    important, because it allows this change to apply even to requests
    using an old API version, thus making these versions usable after
    the mandatory switch to resource classes in nova.

    Change-Id: I58232d9c92d6ffca49d334e5fb7078bce19f1cb4
    Closes-Bug: #1732190

Changed in ironic:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to ironic (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/523131

Revision history for this message
Ruby Loo (rloo) wrote :

Julia and Sam +2'd the code, so let's assume this was approved :) Note that this new config is not tied to any API microversion.

tags: added: rfe-approved
removed: rfe
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to ironic (master)

Reviewed: https://review.openstack.org/523131
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=b5f3dfc2884e986121bf9c92e2e0ca1c1dca71b1
Submitter: Zuul
Branch: master

commit b5f3dfc2884e986121bf9c92e2e0ca1c1dca71b1
Author: Ruby Loo <email address hidden>
Date: Mon Nov 27 09:19:35 2017 -0500

    ironic.conf.sample includes default_resource_class

    This updates ironic.conf.sample to include the new configuration
    option default_resource_class. This is a followup to
    265993316b53abac234600b4b516965b82270e16.

    Change-Id: I7615167c331f7db16b27575affb5c4ea66228a5f
    Related-Bug: #1732190

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-ironic (master)

Reviewed: https://review.openstack.org/523089
Committed: https://git.openstack.org/cgit/openstack/puppet-ironic/commit/?id=907e5b96137f7a4dd104effec904e5450faefd49
Submitter: Zuul
Branch: master

commit 907e5b96137f7a4dd104effec904e5450faefd49
Author: Dmitry Tantsur <email address hidden>
Date: Mon Nov 27 12:11:32 2017 +0100

    Support setting the default_resource_class option

    Change-Id: I4f27bc75e04229fa836c386c4800979074e2827e
    Depends-On: I58232d9c92d6ffca49d334e5fb7078bce19f1cb4
    Closes-Bug: #1732190

Changed in puppet-ironic:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-ironic 12.1.0

This issue was fixed in the openstack/puppet-ironic 12.1.0 release.

Changed in tripleo:
milestone: queens-2 → queens-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to instack-undercloud (master)

Fix proposed to branch: master
Review: https://review.openstack.org/526072

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/526078

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to instack-undercloud (master)

Reviewed: https://review.openstack.org/526072
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=f5f37c9534d375c17e995c9487ba2a627514fd7f
Submitter: Zuul
Branch: master

commit f5f37c9534d375c17e995c9487ba2a627514fd7f
Author: Dmitry Tantsur <email address hidden>
Date: Wed Dec 6 14:56:04 2017 +0100

    Set default_resource_class to baremetal

    We already default to this value when enrolling nodes with our workflows, and when
    upgrading an undercloud to Pike. This change ensures that nodes enrolled outside
    of our workflows also default to 'baremetal'.

    Change-Id: Iee8604a6a942c12e6fa6b9cb8ea88a2cee1ead8f
    Partial-Bug: #1732190

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/526078
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=2486af283c25289251401add2168f7e4f210b310
Submitter: Zuul
Branch: master

commit 2486af283c25289251401add2168f7e4f210b310
Author: Dmitry Tantsur <email address hidden>
Date: Wed Dec 6 15:05:50 2017 +0100

    undercloud: set default_resource_class to 'baremetal'

    We already default to this value when enrolling nodes with our workflows, and when
    upgrading an undercloud to Pike. This change ensures that nodes enrolled outside
    of our workflows also default to 'baremetal'.

    A similar change to instack-undercloud is Iee8604a6a942c12e6fa6b9cb8ea88a2cee1ead8f

    Change-Id: I8c3c45810571a5d58d8d3c21561b96186d2ebbb2
    Partial-Bug: #1732190

Dmitry Tantsur (divius)
Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ironic 10.0.0

This issue was fixed in the openstack/ironic 10.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.