expanding effect units makes skins flicker

[Be]

This happens with both Deere and Tango for me. At first I thought it might be an issue with the Components library changing show_focus and show_parameters simultaneously, but testing it further showed that isn't the issue.

[Be (be.ing)]

Can others reproduce this? Any clues how to resolve or work around it?

[Uwe Klotz (uklotzde-deactivatedaccount)]

I remember I noticed this when expanding the beats/bpm sections above the players in Deere. But now after the Deere 2.1 PR update the flickering is gone.

[Be (be.ing)]

I hope this is not the case, but we may just be running into the limitations of Qt4 with this.

[ronso0 (ronso0)]

What kind of flickering?
The whole skin? Regions below the FX units? FX units only?

[ronso0 (ronso0)]

Ah now I see what you mean:
when expanding an effect unit in Tango we actually toggle visibility On/Off for expanded and collapsed unit at the same time. When cycling expand/collapse/expand none of them is visible for a fraction of a second. At this moment when the opposing effect unit tries to expand in width since both expanded and collapsed are in a horizontal layout.
The symptom can be shifted to collapsing when the I re-order expanded/collapsed units in fx_units_12.xml

[ronso0 (ronso0)]

Working solution for Tango I just tested, is to pack each effect unit's expanded and collapsed version into a vertical layout.

Looking closer I can see a similar issue in Tango when big cover is enabled and channel mixer is switched on. Nesting doesn't solve the 'problem' there.
But putting the mixer before Spinny/Cover in deck xml shifts the issue to disabling the mixer. I think this is better because IMO the mixer is enabled when you urgently need control over EQ etc. and a flickering could hint to some unreliability, but when switching back to Cover this has less impact on UX I'd say.

[ronso0 (ronso0)]

In Deere I can reproduce any flickering only when toggling parallel waveforms,
and then it's literally a white-out for ~1-2 seconds (I have quad-core CPU @2,4GHz).
I'll have a look if skin.xml can be refactored to solve this.

[Be (be.ing)]

Cool, I'm glad you've found a solution. I've been pretty stumped by this.

I'm not sure if the delay when toggling parallel waveforms is the same issue. I think that may be caused by reparenting singletons, particularly the waveforms.

[ronso0 (ronso0)]

Yes, stacked waveforms delay in Deere was due to the large MainSection singleton. It's much better now. It's fixed with https://github.com/Be-ing/mixxx/pull/15/commits/7fb87ecc135e883a1c4e39fe29c26bb30848fc3f
For effect units I can't reproduce it.

Regarding Tango (mixer/cover art) I'll open a PR soon.

[ronso0 (ronso0)]

Let me know if you find any other skin issues.
I have some spare this week and could fix some stuff for 2.1

[ronso0 (ronso0)]

Tango fix:
https://github.com/mixxxdj/mixxx/pull/1380

[ronso0 (ronso0)]

Putting both versions of an effect unit into a WidgetStack works well in Tango and LateNight. I'll implement this in Deere as well the next days.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8971