Enhance SIP support for fine item detail

[Dan Pearl]

There is existing support in SIP to generate fine item detail. This is hardwired to provide a 3M-style of output. While the 3M format is practically a defacto standard, other providers of self-check equipment have specified their own, incompatible formats.

This is a wishlist item to provide configurable support for other manufacturer's equipment.

This requires a change to the SIP product and to the Evergreen product.

[Dan Pearl (dpearl)]

I have implementation currently in internal review.

[Dan Pearl (dpearl)]

As it turns out, there was no change needed to the SIP product (just the Evergreen)

Internal review and testing complete.

Branch at working
user/dpearl/LP1731021_fine_item_detail

[Jason Stephenson (jstephenson)]

I am assigning myself to see if the vendor is still interested in testing this before it goes in.

[Mike Rylander (mrylander)]

If this does end up going in, I think the setting should probably be moved to be an attribute on the <login> element. That ties the format to the specific client, rather that setting it for an entire <institution>. Opinions?

[Jason Stephenson (jstephenson)]

So, I was not thinking straight when I took this bug over. I don't have time to look at it right now. I'm assigning it to Dan Pearl and will ask him to do the testing with the vendor and to make the changes from Mike's comment #4.

[Jason Stephenson (jstephenson)]

I am reworking Dan's branch and may just start this over.

[Jason Stephenson (jstephenson)]

And, I'm not really working on this any more.

[Bill Erickson (berick)]

Kicking the dust off this one. Will post a follow-up branch soon.

[Bill Erickson (berick)]

New branch pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1731021-sip-fine-item-detail

* Adds a sign-off to Dan's first commit.
* Implements Dan's second commit manually since the working branch was not in a usable state (merge conflict markers, unintended deletions, etc.)
* Migrates the title/author retrieval code to use metabib display fields instead of MVR's.
* General code cleanup

As an example, here's a debug excerpt from SIP call (using pysip2) to a server configured to use "3m" AV format:

[AV] fine items : 487 $3.33 "FINE" Misc test test
[AV] fine items : 313 $0.20 "FINE" Overdue materials Piano concerto no. 2, op. 83, B flat major/Brahms, Johannes 1833-1897
[AV] fine items : 315 $0.90 "FINE" Overdue materials Four concertos with oboe and string orchestra/Handel, George Frideric 1685-1759
[AV] fine items : 316 $3.00 "FINE" Overdue materials The Baroque concerto/Hutchings, Arthur 1906-
[AV] fine items : 318 $2.30 "FINE" Overdue materials Complete transcriptions, cadenzas, and exercises, for solo piano/Brahms, Johannes 1833-1897
[AV] fine items : 314 $1.70 "FINE" Overdue materials Concerto, op. 4, no. 6, B flat major ; Concerto, op. 4, no. 5, F major ; Concerto grosso, C major (Alexander's feast)/Handel, George Frideric 1685-1759

[Bill Erickson (berick)]

I have pushed another commit to this branch integrating some additional features coded by Jason Stephenson (see working/user/dyrcona/sip2-envisionware-fid) to support specifying the fee type as fine/fee/lost depending on the last billing type of each transaction.

[Galen Charlton (gmc)]

Pushed to master for inclusion in 3.4. Thanks, Dan and Bill!