Wrong permissions to local_settings.d in dockerized Horizon

Bug #1730911 reported by Radomir Dopieralski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Radomir Dopieralski

Bug Description

The docker Horizon image has wrong permissions for the local_settings.d directory. This is normally not visible, as Horizon simply ignores configuration files that it doesn't have access to (we will fix that separately), but it results in OfflineGenerationError for the offline compressor when a theme configuration is placed in that directory, as we do in our downstream releases. Then, when "manage.py compress" is run as root, it sees different CSS files (enabled by the theme configuration) than when Horizon is ran by Apache, resulting in different hashes for the compiled files, and ultimately errors.

Changed in heat-templates:
assignee: nobody → Radomir Dopieralski (deshipu)
Martin André (mandre)
affects: heat-templates → tripleo
Changed in tripleo:
status: New → Triaged
importance: Undecided → High
milestone: none → queens-2
tags: added: containers
tags: added: pike-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/518533

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/518384
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=2827fa428c757180019dd7c1aacafcca554845ab
Submitter: Zuul
Branch: master

commit 2827fa428c757180019dd7c1aacafcca554845ab
Author: Radomir Dopieralski <email address hidden>
Date: Tue Nov 7 20:20:38 2017 +0100

    Fix rights to local_settings.d for dockerized Horizon

    For some reasonf that directory doesn't have r/x rights, so when
    compress is ran as root, it can access config files in it, but when
    horizon is run by apache, it can't, and expects different theme files,
    thus failing with OfflineGenerationError. Giving apache access to that
    directory fixes the problem and makes the custom theme work.

    Closes-bug: #1730911
    Change-Id: I53f6db23b036bc9b5a689bbac958550f384194c6

Changed in tripleo:
status: Triaged → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/pike)

Reviewed: https://review.openstack.org/518533
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=efcd879b863d0e597f0b10b5df7ec74690aa23e5
Submitter: Zuul
Branch: stable/pike

commit efcd879b863d0e597f0b10b5df7ec74690aa23e5
Author: Radomir Dopieralski <email address hidden>
Date: Tue Nov 7 20:20:38 2017 +0100

    Fix rights to local_settings.d for dockerized Horizon

    For some reasonf that directory doesn't have r/x rights, so when
    compress is ran as root, it can access config files in it, but when
    horizon is run by apache, it can't, and expects different theme files,
    thus failing with OfflineGenerationError. Giving apache access to that
    directory fixes the problem and makes the custom theme work.

    Closes-bug: #1730911
    Change-Id: I53f6db23b036bc9b5a689bbac958550f384194c6
    (cherry picked from commit 2827fa428c757180019dd7c1aacafcca554845ab)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 7.0.4

This issue was fixed in the openstack/tripleo-heat-templates 7.0.4 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 8.0.0.0b2

This issue was fixed in the openstack/tripleo-heat-templates 8.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.