OVN configures ovn-bridge-mappings on all the nodes even if they don't provide external connectivity

[Numan Siddique]

For OVN deployments, in order for any node (be it compute or controller) to provide external connectivity to the tenant traffic, ovn-controller service should be running and the ovn-bridge-mappings (eg. OVNBridgeMappings=datacentre:br-ex) should be defined. Tripleo when deployed with OVN does it, but it does on all the nodes where (ovn-controller service is enabled) even if those nodes do not have external connectivity. Neutron ML2 OVN driver considers all the nodes configured with "ovn-bridge-mappings" as candidates and could schedule on any node. This will cause problems on deployments where only controller (or network) nodes provide external connectivity.

This should be fixed.

[Steven Hardy (shardy)]

Fix proposed at https://review.openstack.org/#/c/518440/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/519680

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/518440
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=1e43e5b08f9d324e910cf1842d566d2372e5aeff
Submitter: Zuul
Branch: master

commit 1e43e5b08f9d324e910cf1842d566d2372e5aeff
Author: Numan Siddique <email address hidden>
Date: Wed Nov 8 09:23:08 2017 +0530

    OVN: Provide the option to define NeutronBridgeMappings as a role parameter

    In order for a node to provide external connectivity to tenant traffic,
    ovn-bridge-mappings should be defined which is read by ovn-controller service.
    This value comes from the T-H-T param 'NeutronBridgeMappings'. Presently
    this param is defined with the default value "datacentre:br-ex" and is configured
    on every node where ovn-controller service is enabled. This would cause problems
    if some of the hosts do not provide external connectvity.

    To solve this problem, this patch adds 'NeutronBridgeMappings' as a role parameter
    so that it can set to empty string if the role doesn't provide external connectivity.

    In the OVN environment template files, this param is set to empty for Compute role.

    Since NeutronBridgeMappings is also used by neutron-ovs-agent service, this patch
    also modifies puppet/services/neutron-ovs-agent.yaml to define NeutronBridgeMappings
    as a role parameter.

    Change-Id: I6a00b8dc1ff387cc5e1e62b4d9d7da5e1239ee31
    Closes-bug: #1730711

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alex Schultz (<email address hidden>) on branch: stable/pike
Review: https://review.openstack.org/519680

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/519680
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=7c3865d213bfb32593a68ab2d774efd131f7f32e
Submitter: Zuul
Branch: stable/pike

commit 7c3865d213bfb32593a68ab2d774efd131f7f32e
Author: Numan Siddique <email address hidden>
Date: Wed Nov 8 09:23:08 2017 +0530

    OVN: Provide the option to define NeutronBridgeMappings as a role parameter

    In order for a node to provide external connectivity to tenant traffic,
    ovn-bridge-mappings should be defined which is read by ovn-controller service.
    This value comes from the T-H-T param 'NeutronBridgeMappings'. Presently
    this param is defined with the default value "datacentre:br-ex" and is configured
    on every node where ovn-controller service is enabled. This would cause problems
    if some of the hosts do not provide external connectvity.

    To solve this problem, this patch adds 'NeutronBridgeMappings' as a role parameter
    so that it can set to empty string if the role doesn't provide external connectivity.

    In the OVN environment template files, this param is set to empty for Compute role.

    Since NeutronBridgeMappings is also used by neutron-ovs-agent service, this patch
    also modifies puppet/services/neutron-ovs-agent.yaml to define NeutronBridgeMappings
    as a role parameter.

    Change-Id: I6a00b8dc1ff387cc5e1e62b4d9d7da5e1239ee31
    Closes-bug: #1730711
    (cherry picked from commit 1e43e5b08f9d324e910cf1842d566d2372e5aeff)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.5 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.0.0.0b2 development milestone.