default timeout is missed in requests session which may hung forever

[Vasyl Saienko]

We should specify default timeout to each request session because if timeout is not set, request may hung, as it is not limited in time by default http://docs.python-requests.org/en/master/user/quickstart/#timeouts

One of examples is https://github.com/openstack/ironic-python-agent/blob/fd7f10b993ef5262e76d604b38cfad25aed2266d/ironic_python_agent/ironic_api_client.py#L64

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/518322

[Vasyl Saienko (vsaienko)]

ironicclient also affected, any api request may hung forever when API is not available
$ date; ironic --ironic-url http://5.2.3.4 node-list
Wed Nov 15 09:14:00 UTC 2017
The "ironic" CLI is deprecated and will be removed in the S* release. Please use the "openstack baremetal" CLI instead.
^C... terminating ironic client
$ date
Wed Nov 15 09:15:50 UTC 2017
$

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/520056

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/537311

[OpenStack Infra (hudson-openstack)]

Change abandoned by ya.wang ([e-mail]) on branch: master
Review: https://review.openstack.org/537311

[Jay Faulkner (jason-oldos)]

https://github.com/openstack/ironic-python-agent/blob/master/ironic_python_agent/ironic_api_client.py#L85

This functionality is in IPA now.

[Jay Faulkner (jason-oldos)]

Looks like we still have some missing timeouts in python-ironicclient:
- https://github.com/openstack/python-ironicclient/blob/1a11b9c463bb68aed2f37c9c1ff74e86c6aa294c/ironicclient/common/http.py#L377C31
(not comprehensive list)