PciPassthroughFilter always added to filter list

[Edward Hope-Morley]

Currently the nova-cloud-controller will always add PciPassthroughFilter to scheduler_default_filters in nova.conf. This is because the code is reading the enable-sriov setting as boolean on the neutron-api relation when in fact booleans are always converted to strings meaning that this will always be true (e.g. if set to "False").

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/517934

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/517934
Committed: https://git.openstack.org/cgit/openstack/charm-nova-cloud-controller/commit/?id=05ea3a13f1bf14938069238902008edbef69b4b3
Submitter: Zuul
Branch: master

commit 05ea3a13f1bf14938069238902008edbef69b4b3
Author: Edward Hope-Morley <email address hidden>
Date: Mon Nov 6 12:03:27 2017 +0000

    Only use PciPassthroughFilter when sriov enabled

    Fixes code that inadvertently interprets strings as
    booleans resulting in them always being True.
    PciPassthroughFilter will now only be added to
    scheduler_default_filters if sriov is enabled.

    Change-Id: Ie2c79e98d7880e8172ac7e77febb51af04732bec
    Closes-Bug: 1730369