keystone raise 500 error when authenticate with "mapped"

Bug #1730270 reported by wangxiyuan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
wangxiyuan

Bug Description

When authenticate with "mapped" method, if users forget to add "identity_provider" or "protocol" keypair, keystone will raise 500 error.

In this case, keystone should raise 400 Bad Request.

Tags: office-hours
wangxiyuan (wangxiyuan)
Changed in keystone:
assignee: nobody → wangxiyuan (wangxiyuan)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/517854

Changed in keystone:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/517854
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=503882cb8c251cc948d50d07083666df439bf215
Submitter: Zuul
Branch: master

commit 503882cb8c251cc948d50d07083666df439bf215
Author: wangxiyuan <email address hidden>
Date: Mon Nov 6 11:58:56 2017 +0800

    Fix 500 error when authenticate with "mapped"

    When authenticate with "mapped" method, if users forget to add
    "identity_provider" or "protocol" keypair, keystone will raise
    500 error.

    In this case, keystone should raise 400 error(ValidationError).

    Change-Id: I85feb078b7fb2a5b091407fa69db7409a9c75199
    Closes-bug: #1730270

Changed in keystone:
status: In Progress → Fix Released
Revision history for this message
Lance Bragstad (lbragstad) wrote :

According to the API guidelines, we should be able to change a HTTP 500 -> 400. But, we should add some sort of functional test in this case since it's something we can test with the API.

Changed in keystone:
importance: Undecided → Medium
tags: added: office-hours
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/keystone 13.0.0.0b2

This issue was fixed in the openstack/keystone 13.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.