puppet-collectd change on datatype

[Emilien Macchi]

https://github.com/voxpupuli/puppet-collectd/commit/15a028feb63f64444ce837c3f7397c46d219d13e

We need to update the datatype for the 'connection' parameter and make sure it's a string.

Nov 1 23:28:43 localhost os-collect-config: "Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, Class[Collectd::Plugin::Virt]: parameter 'connection' expects a String value, got Undef at /etc/puppet/modules/tripleo/manifests/profile/base/metrics/collectd/collectd_plugin.pp:5:3 at /etc/puppet/modules/tripleo/manifests/profile/base/metrics/collectd/collectd_service.pp:8 on node centos-7-rax-dfw-0000664656.localdomain",

http://logs.openstack.org/38/516138/3/check/legacy-tripleo-ci-centos-7-scenario001-multinode-oooq/21678ad/logs/subnode-2/var/log/messages.txt.gz#_Nov__1_23_28_43

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/517147

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/517147
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=24f859c01826eb12256cf1a5cd63b8bb1c0e234c
Submitter: Zuul
Branch: master

commit 24f859c01826eb12256cf1a5cd63b8bb1c0e234c
Author: Emilien Macchi <email address hidden>
Date: Wed Nov 1 18:22:16 2017 -0700

    Fix nova-cpu/collectd hieradata

    Probably a typo, never caught or even tested.

    Change-Id: Iaf75edb421a19cb69bf3ead59c83bf812c653f0b
    Closes-Bug: #1729479

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/517352

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/517353

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/517352
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=4a08ce600fe7c3da33acc0a4365508236263a72a
Submitter: Zuul
Branch: stable/pike

commit 4a08ce600fe7c3da33acc0a4365508236263a72a
Author: Emilien Macchi <email address hidden>
Date: Wed Nov 1 18:22:16 2017 -0700

    Fix nova-cpu/collectd hieradata

    Probably a typo, never caught or even tested.

    Change-Id: Iaf75edb421a19cb69bf3ead59c83bf812c653f0b
    Closes-Bug: #1729479
    (cherry picked from commit 24f859c01826eb12256cf1a5cd63b8bb1c0e234c)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/517353
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=5d1d32d8785c60eb8cdec0494f8078b4e34c2414
Submitter: Zuul
Branch: stable/ocata

commit 5d1d32d8785c60eb8cdec0494f8078b4e34c2414
Author: Emilien Macchi <email address hidden>
Date: Wed Nov 1 18:22:16 2017 -0700

    Fix nova-cpu/collectd hieradata

    Probably a typo, never caught or even tested.

    Change-Id: Iaf75edb421a19cb69bf3ead59c83bf812c653f0b
    Closes-Bug: #1729479
    (cherry picked from commit 24f859c01826eb12256cf1a5cd63b8bb1c0e234c)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.4 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.2.5 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.0.0.0b2 development milestone.