added level of indirection causes incorrect hiera config for big switch networks plugin

[Aditya Vaja]

Description:
Until Openstack Newton, neutron-ml2-bigswitch.yaml had `mapped_data` as part of resource definition. However, Ocata onwards, this doesn't work as the `mapped_data` is added as a dictionary key to the final hiera config file neutron_bigswitch_data.json under /etc/puppet/hieradata.

Steps to Reproduce:
1. Follow the deployment guide and install Openstack Ocata with bigswitch components

Expected results:
/etc/neutron/plugins/ml2/ml2_conf.ini should have [restproxy] section and along with that, the added properties as specified under neutron_bigswitch_data

Actual results:
/etc/neutron/plugins/ml2/ml2_conf.ini has [restproxy] section but all values are populated by the defaults set. None of the properties specified under neutron_bigswitch_data are picked up.

Environment:
Ocata

We identified a fix and proposed it in the master branch https://review.openstack.org/#/c/508369/
This would have to be cherry-picked to pike and ocata.

[Alex Schultz (alex-schultz)]

for pike: https://review.openstack.org/#/c/517113/
for ocata: https://review.openstack.org/#/c/517104/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/517113
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=a73cfc001baa2759f2e3e290ad21afde1381766c
Submitter: Zuul
Branch: stable/pike

commit a73cfc001baa2759f2e3e290ad21afde1381766c
Author: Aditya Vaja <email address hidden>
Date: Thu Sep 28 17:33:13 2017 -0700

    added level of indirection causes incorrect hiera config

     - until Newton this worked fine, however starting with Ocata, we
       do not need the key 'mapped_data'
     - having it results in extra indirection in the dictionary in
       neutron_bigswitch_data.json

    Closes-Bug: #1729453

    Change-Id: I3bc9940aeff4e290d83de95a7df294c11f061954
    (cherry picked from commit 485339129cee8f5d3223cf47858a5c9f79b0a8de)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/517104
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=72b33c9396fd6824c96e03d45ceb99b0cf6d1452
Submitter: Zuul
Branch: stable/ocata

commit 72b33c9396fd6824c96e03d45ceb99b0cf6d1452
Author: Aditya Vaja <email address hidden>
Date: Thu Sep 28 17:33:13 2017 -0700

    added level of indirection causes incorrect hiera config

     - until Newton this worked fine, however starting with Ocata, we
       do not need the key 'mapped_data'
     - having it results in extra indirection in the dictionary in
       neutron_bigswitch_data.json

    Closes-Bug: #1729453

    Change-Id: I3bc9940aeff4e290d83de95a7df294c11f061954
    (cherry picked from commit 485339129cee8f5d3223cf47858a5c9f79b0a8de)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.4 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.2.5 release.