stop hook fails

[Chris MacNaughton]

The Ceph charm fails its stop hook with Xenial-Pike (Luminous)

2017-10-25 20:16:08 DEBUG stop no valid command found; 10 closest matches:
2017-10-25 20:16:08 DEBUG stop mon stat
2017-10-25 20:16:08 DEBUG stop mon dump {<int[0-]>}
2017-10-25 20:16:08 DEBUG stop mon remove <name>
2017-10-25 20:16:08 DEBUG stop mon add <name> <IPaddr[:port]>
2017-10-25 20:16:08 DEBUG stop mon getmap {<int[0-]>}
2017-10-25 20:16:08 DEBUG stop Error EINVAL: invalid command
2017-10-25 20:16:08 DEBUG stop Traceback (most recent call last):
2017-10-25 20:16:08 DEBUG stop File "/var/lib/juju/agents/unit-ceph-0/charm/hooks/stop", line 688, in <module>
2017-10-25 20:16:08 DEBUG stop hooks.execute(sys.argv)
2017-10-25 20:16:08 DEBUG stop File "/var/lib/juju/agents/unit-ceph-0/charm/hooks/charmhelpers/core/hookenv.py", line 773, in execute
2017-10-25 20:16:08 DEBUG stop self._hooks[hook_name]()
2017-10-25 20:16:08 DEBUG stop File "/var/lib/juju/agents/unit-ceph-0/charm/hooks/stop", line 671, in stop
2017-10-25 20:16:08 DEBUG stop subprocess.check_call(cmd)
2017-10-25 20:16:08 DEBUG stop File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
2017-10-25 20:16:08 DEBUG stop raise CalledProcessError(retcode, cmd)
2017-10-25 20:16:08 DEBUG stop subprocess.CalledProcessError: Command '['ceph', 'mon', 'rm', 'juju-814f93-auto-osci-sv04-0']' returned non-zero exit status 22
2017-10-25 20:16:08 ERROR juju.worker.uniter.operation runhook.go:107 hook "stop" failed: exit status 1

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/517220

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/517220
Committed: https://git.openstack.org/cgit/openstack/charm-ceph/commit/?id=0a298a732de881fc566f5a41c942535c3b7657a4
Submitter: Zuul
Branch: master

commit 0a298a732de881fc566f5a41c942535c3b7657a4
Author: James Page <email address hidden>
Date: Thu Nov 2 09:13:57 2017 +0000

    migration: Superceed use of 'ceph mon rm'

    Use the remove command (instead of rm) which is supported in
    Ceph firefly or later (which covers all current deployment targets).

    This resolves an issue with the ceph -> ceph-mon/ceph-osd migration
    process for Luminous based deployments.

    Change-Id: I127930e7c4b80465796b8270a9966b08f7c03037
    Closes-Bug: 1729370