ansible-2.4: specifying vars before children in inventory file causes no hosts to match

[James Slagle]

The static inventory generated by tripleo-ansible-inventory has the :vars sections before the :children sections. This worked fine with ansible 2.3 versions. However, since ansible 2.4 was released, this has caused no hosts to match the generated inventory.

Detailed ansible issue:
https://github.com/ansible/ansible/issues/32196

We can work around this in tripleo-ansible-inventory by specifying the :vars sections after the :children sections.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/516764

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/516764
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=ff37e696c375c7ec388c6b9ac160ead38809877e
Submitter: Zuul
Branch: master

commit ff37e696c375c7ec388c6b9ac160ead38809877e
Author: James Slagle <email address hidden>
Date: Tue Oct 31 14:36:21 2017 -0400

    Specify vars after children sections

    Changes how the vars and children sections are ordered in the generated
    static inventory by tripleo-ansible-inventory. Due to a change in
    ansible 2.4, having them in the opposite order caused no hosts to match
    the inventory.

    See also:
    https://github.com/ansible/ansible/issues/32196

    Change-Id: I2aa1a04ea8a963b9c613008c12b1efffd365ceaf
    implements: blueprint ansible-config-download
    Closes-Bug: #1729058

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-validations 8.1.0 release.