[newton only] Double sed backup remove original file during upgrade.

[Sofer Athlan-Guyot]

Hi,

just code reading I bumped into this issue[1]. The problem is the sed is inside the loop and there are 2 services. The second sed (because of -i.orig) erase the original file which won't be restored at the end.

The impact is nearly non-existent as we don't use /usr/lib/ocf/lib/neutron/neutron-netns-cleanup, like never again.

[1] https://github.com/openstack/tripleo-heat-templates/blob/stable/newton/extraconfig/tasks/major_upgrade_pacemaker_migrations.sh#L119..L120

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/516676

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/516676
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=7b1be85b95144c92a1f775376a515444def5baa0
Submitter: Zuul
Branch: stable/newton

commit 7b1be85b95144c92a1f775376a515444def5baa0
Author: Sofer Athlan-Guyot <email address hidden>
Date: Tue Oct 31 14:28:25 2017 +0100

    [Newton only] Fix double sed backup during upgrade.

    By having the sed inside the loop we have it run twice. This has the
    effect of erasing the original backup which can’t be restored.

    It has no other effect as we don’t use
    /usr/lib/ocf/lib/neutron/neutron-netns-cleanup anymore.

    Change-Id: I868462ce25185de7f76a6b06137aaa545daf48c4
    Closes-Bug: #1728979

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 5.3.5 release.

[Sofer Athlan-Guyot (sofer-athlan-guyot)]

Fix released see https://bugs.launchpad.net/tripleo/+bug/1728979/comments/3