[mainline,R4.1] vcenter-only provisioning: is_xenial_or_above() def is missing in manage_dvs_pg

[Pavana]

On mainline~93 and R4.1, vcenter-only provisioning doesn't work since is_xenial_or_above() def is missing in manage_dvs_pg.py but is trying to be imported into deploy_contrail_vm.py

"item": {
        "ansible_job_id": "380562562346.10265",
        "changed": true,
        "finished": 0,
        "results_file": "/root/.ansible_async/380562562346.10265",
        "started": 1
    },
    "rc": 1,
    "start": "2017-10-31 11:03:20.395796",
    "stderr": "Traceback (most recent call last):\n File \"/opt/contrail/server_manager/deploy_contrail_vm.py\", line 13, in <module>\n from manage_dvs_pg import get_obj, is_xenial_or_above\nImportError: cannot import name is_xenial_or_above",
    "stderr_lines": [
        "Traceback (most recent call last):",
        " File \"/opt/contrail/server_manager/deploy_contrail_vm.py\", line 13, in <module>",
        " from manage_dvs_pg import get_obj, is_xenial_or_above",
        "ImportError: cannot import name is_xenial_or_above" <<<
    ],
    "stdout": "",
    "stdout_lines": []

This is present in R4.0 but not available on R4.1 and mainline branches -->

contrail-server-manager/src/manage_dvs_pg.py -->
def is_xenial_or_above():
    is_xenial_or_above = False
    (dist, version, extra) = get_linux_distro()
    if dist.lower() == 'ubuntu':
       if LooseVersion(version) >= LooseVersion("16.04"):
          is_xenial_or_above = True

    return is_xenial_or_above

contrail-server-manager/src/deploy_contrail_vm.py has the import present though -->
from manage_dvs_pg import get_obj, is_xenial_or_above

[amudhar (amudha)]

Fix committed through below reviews.

https://review.opencontrail.org/#/c/37019/ - R4.1
https://review.opencontrail.org/#/c/37020/ - master

[amudhar (amudha)]

Fix committed through https://bugs.launchpad.net/juniperopenstack/+bug/1713809.
Closing this bug.

[Pavana (pavanap)]

Verified on R4.1~33 and mainline~95